From: Michael Ellerman <mpe@ellerman•id.au>
To: Amit Kumar Mahapatra <amit.kumar-mahapatra@amd•com>, broonie@kernel•org
Cc: linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org,
linux-spi@vger•kernel.org
Subject: Re: [PATCH v4 07/15] powerpc/83xx/mpc832x_rdb: Replace all spi->chip_select references with function call
Date: Tue, 21 Feb 2023 21:50:58 +1100 [thread overview]
Message-ID: <87ilfvb8bx.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20230210193647.4159467-8-amit.kumar-mahapatra@amd.com>
Amit Kumar Mahapatra <amit.kumar-mahapatra@amd•com> writes:
> Supporting multi-cs in spi drivers would require the chip_select & cs_gpiod
> members of struct spi_device to be an array. But changing the type of these
> members to array would break the spi driver functionality. To make the
> transition smoother introduced four new APIs to get/set the
> spi->chip_select & spi->cs_gpiod and replaced all spi->chip_select and
> spi->cs_gpiod references with get or set API calls.
> While adding multi-cs support in further patches the chip_select & cs_gpiod
> members of the spi_device structure would be converted to arrays & the
> "idx" parameter of the APIs would be used as array index i.e.,
> spi->chip_select[idx] & spi->cs_gpiod[idx] respectively.
>
> Signed-off-by: Amit Kumar Mahapatra <amit.kumar-mahapatra@amd•com>
> ---
> arch/powerpc/platforms/83xx/mpc832x_rdb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/83xx/mpc832x_rdb.c b/arch/powerpc/platforms/83xx/mpc832x_rdb.c
> index caa96edf0e72..4ab1d48cd229 100644
> --- a/arch/powerpc/platforms/83xx/mpc832x_rdb.c
> +++ b/arch/powerpc/platforms/83xx/mpc832x_rdb.c
> @@ -144,7 +144,7 @@ static int __init fsl_spi_init(struct spi_board_info *board_infos,
>
> static void mpc83xx_spi_cs_control(struct spi_device *spi, bool on)
> {
> - pr_debug("%s %d %d\n", __func__, spi->chip_select, on);
> + pr_debug("%s %d %d\n", __func__, spi_get_chipselect(spi, 0), on);
> par_io_data_set(3, 13, on);
> }
Better to just delete the pr_debug(), it's disabled by default and I
doubt anyone will ever enable it again in code that old.
cheers
next prev parent reply other threads:[~2023-02-21 10:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 19:36 [PATCH v4 00/15] spi: Add support for stacked/parallel memories Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 01/15] spi: Replace all spi->chip_select and spi->cs_gpiod references with function call Amit Kumar Mahapatra
2023-02-15 14:19 ` Mark Brown
2023-02-10 19:36 ` [PATCH v4 02/15] net: " Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 03/15] iio: imu: " Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 04/15] mtd: devices: " Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 05/15] staging: " Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 06/15] platform/x86: serial-multi-instantiate: " Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 07/15] powerpc/83xx/mpc832x_rdb: Replace all spi->chip_select " Amit Kumar Mahapatra
2023-02-21 10:50 ` Michael Ellerman [this message]
2023-02-10 19:36 ` [PATCH v4 08/15] ALSA: hda: cs35l41: " Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 09/15] spi: Add stacked and parallel memories support in SPI core Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 10/15] mtd: spi-nor: Convert macros with inline functions Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 11/15] mtd: spi-nor: Add APIs to set/get nor->params Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 12/15] mtd: spi-nor: Add stacked memories support in spi-nor Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 13/15] spi: spi-zynqmp-gqspi: Add stacked memories support in GQSPI driver Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 14/15] mtd: spi-nor: Add parallel memories support in spi-nor Amit Kumar Mahapatra
2023-02-10 19:36 ` [PATCH v4 15/15] spi: spi-zynqmp-gqspi: Add parallel memories support in GQSPI driver Amit Kumar Mahapatra
2023-03-11 21:16 ` (subset) [PATCH v4 00/15] spi: Add support for stacked/parallel memories Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilfvb8bx.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=amit.kumar-mahapatra@amd$(echo .)com \
--cc=broonie@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-spi@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox