From: Michael Ellerman <mpe@ellerman•id.au>
To: Ram Pai <linuxram@us•ibm.com>
Cc: Florian Weimer <fweimer@redhat•com>,
linuxppc-dev@lists•ozlabs.org, dave.hansen@intel•com,
aneesh.kumar@linux•vnet.ibm.com, bsingharora@gmail•com,
hbabu@us•ibm.com, mhocko@kernel•org, bauerman@linux•vnet.ibm.com,
Ulrich.Weigand@de•ibm.com, luto@kernel•org, msuchanek@suse•de
Subject: Re: [PATCH v2 0/6] powerpc/pkeys: fixes to pkeys
Date: Sun, 24 Jun 2018 01:02:50 +1000 [thread overview]
Message-ID: <87in69eeat.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20180621181045.GL5294@ram.oc3035372033.ibm.com>
Ram Pai <linuxram@us•ibm.com> writes:
> On Thu, Jun 21, 2018 at 08:28:47PM +1000, Michael Ellerman wrote:
>> Florian Weimer <fweimer@redhat•com> writes:
>> > On 06/19/2018 02:40 PM, Michael Ellerman wrote:
>> >>> I tested the whole series with the new selftests, with the printamr.c
>> >>> program I posted earlier, and the glibc test for pkey_alloc &c. The
>> >>> latter required some test fixes, but now passes as well. As far as I
>> >>> can tell, everything looks good now.
>> >>>
>> >>> Tested-By: Florian Weimer<fweimer@redhat•com>
>> >> Thanks. I'll add that to each patch I guess, if you're happy with that?
>> >
>> > Sure, but I only tested the whole series as a whole.
>>
>> Yeah OK. We don't have a good way to express that, other than using a
>> merge which I'd prefer to avoid.
>>
>> So I've tagged them all with your Tested-by. If any of them turn out to
>> have bugs you can blame me :)
>
> I just tested the patches incrementally using the pkey selftests.
>
> So I feel confident these patches are not bugs. I will take the blame
> if the blame lands on Mpe :)
Did you run core-pkey and ptrace-pkey?
The pkey selftests that are in tools/testing/selftests/powerpc/ptrace ?
Because those are failing for me:
test: core_pkey
tags: git_version:c899d94
[FAIL] Test FAILED on line 245
[Core Read (Running)] AMR: 3fcfffffffffffff IAMR: 1105555555555555 UAMOR: 33cfffffffffffff
failure: core_pkey
test: ptrace_pkey
tags: git_version:c899d94
[FAIL] Test FAILED on line 214
[Ptrace Read (Running)] AMR: 3fcfffffffffffff IAMR: 1105555555555555 UAMOR: 33cfffffffffffff
[User Write (Running)] AMR: 3fffffffffffffff pkey1: 3 pkey2: 4 pkey3: 5
failure: ptrace_pkey
Some of which is presumably test case bugs, but there's at least one
kernel bug with the UAMOR handling.
So this series will have to wait until next week :/
cheers
next prev parent reply other threads:[~2018-06-23 15:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 0:28 [PATCH v2 0/6] powerpc/pkeys: fixes to pkeys Ram Pai
2018-06-14 0:28 ` [PATCH v2 1/6] powerpc/pkeys: Enable all user-allocatable pkeys at init Ram Pai
2018-06-19 12:39 ` Michael Ellerman
2018-06-19 14:25 ` Ram Pai
2018-06-21 4:14 ` Michael Ellerman
2018-06-21 17:24 ` Ram Pai
2018-06-14 0:29 ` [PATCH v2 2/6] powerpc/pkeys: Save the pkey registers before fork Ram Pai
2018-06-19 12:39 ` Michael Ellerman
2018-06-19 14:28 ` Ram Pai
2018-06-21 4:13 ` Michael Ellerman
2018-06-21 17:35 ` Ram Pai
2018-06-14 0:29 ` [PATCH v2 3/6] powerpc/pkeys: fix calculation of total pkeys Ram Pai
2018-06-19 12:40 ` Michael Ellerman
2018-06-14 0:29 ` [PATCH v2 4/6] powerpc/pkeys: Preallocate execute-only key Ram Pai
2018-06-19 12:40 ` Michael Ellerman
2018-06-19 16:38 ` Ram Pai
2018-06-21 0:28 ` Michael Ellerman
2018-06-29 3:02 ` Thiago Jung Bauermann
2018-06-14 0:29 ` [PATCH v2 5/6] powerpc/pkeys: make protection key 0 less special Ram Pai
2018-06-19 12:40 ` Michael Ellerman
2018-06-19 16:34 ` Ram Pai
2018-06-14 0:29 ` [PATCH v2 6/6] powerpc/pkeys: Deny read/write/execute by default Ram Pai
2018-06-19 12:39 ` Michael Ellerman
2018-06-19 13:19 ` Florian Weimer
2018-06-19 16:31 ` Ram Pai
2018-06-14 12:15 ` [PATCH v2 0/6] powerpc/pkeys: fixes to pkeys Florian Weimer
2018-06-19 12:40 ` Michael Ellerman
2018-06-20 15:08 ` Florian Weimer
2018-06-21 10:28 ` Michael Ellerman
2018-06-21 18:10 ` Ram Pai
2018-06-23 15:02 ` Michael Ellerman [this message]
2018-06-25 17:06 ` Ram Pai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87in69eeat.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=Ulrich.Weigand@de$(echo .)ibm.com \
--cc=aneesh.kumar@linux$(echo .)vnet.ibm.com \
--cc=bauerman@linux$(echo .)vnet.ibm.com \
--cc=bsingharora@gmail$(echo .)com \
--cc=dave.hansen@intel$(echo .)com \
--cc=fweimer@redhat$(echo .)com \
--cc=hbabu@us$(echo .)ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=linuxram@us$(echo .)ibm.com \
--cc=luto@kernel$(echo .)org \
--cc=mhocko@kernel$(echo .)org \
--cc=msuchanek@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox