Subject: Re: [PATCH V5] powerpc/mpc512x: Add gpio driver

From: Peter Korsgaard <[email-masked]>
Date: Wed, 07 Jul 2010 13:28:53 +0200

>>>>> "Anatolij" == Anatolij Gustschin <[email-masked]> writes:

Hi,

Old mail, I know ..

 Anatolij> From: Matthias Fuchs <[email-masked]>
 Anatolij> This patch adds a gpio driver for MPC512X PowerPCs.

 Anatolij> It has been tested on our CAN-CBX-CPU5201 module that
 Anatolij> uses a MPC5121 CPU. This platform comes with a couple of
 Anatolij> LEDs and configuration switches that have been used for testing.

 Anatolij> After change to the of-gpio api the reworked driver has been
 Anatolij> tested on pdm360ng board with some configuration switches.

This looks very similar to the existing
arch/powerpc/sysdev/mpc8xxx_gpio.c - Couldn't we just add 5121 support
there instead?

 Anatolij> +struct mpc512x_gpio_regs {
 Anatolij> +	u32 gpdir;
 Anatolij> +	u32 gpodr;
 Anatolij> +	u32 gpdat;
 Anatolij> +	u32 gpier;
 Anatolij> +	u32 gpimr;
 Anatolij> +	u32 gpicr1;
 Anatolij> +	u32 gpicr2;
 Anatolij> +};

-- 
Bye, Peter Korsgaard