From: Esben Haabendal <esben@geanix•com>
To: Christophe Leroy <christophe.leroy@csgroup•eu>
Cc: Michael Walle <mwalle@kernel•org>,
Vignesh Raghavendra <vigneshr@ti•com>,
Richard Weinberger <richard@nod•at>,
Nicholas Piggin <npiggin@gmail•com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
Krzysztof Kozlowski <krzk@kernel•org>,
"Aneesh Kumar K.V" <aneesh.kumar@kernel•org>,
Tudor Ambarus <tudor.ambarus@linaro•org>,
"linux-mtd@lists•infradead.org" <linux-mtd@lists•infradead.org>,
Miquel Raynal <miquel.raynal@bootlin•com>,
"Naveen N. Rao" <naveen.n.rao@linux•ibm.com>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
Pratyush Yadav <pratyush@kernel•org>
Subject: Re: [PATCH v2 1/2] memory: fsl_ifc: Make FSL_IFC config visible and selectable
Date: Tue, 28 May 2024 15:43:07 +0200 [thread overview]
Message-ID: <87jzjevyqc.fsf@geanix.com> (raw)
In-Reply-To: <56f19120-7ddb-4006-99f6-e1b043ed88e1@kernel.org> (Krzysztof Kozlowski's message of "Tue, 28 May 2024 15:32:12 +0200")
Krzysztof Kozlowski <krzk@kernel•org> writes:
> On 28/05/2024 15:15, Christophe Leroy wrote:
>> Le 28/05/2024 à 14:28, Esben Haabendal a écrit :
>>> [Vous ne recevez pas souvent de courriers de esben@geanix•com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>>>
>>> While use of fsl_ifc driver with NAND flash is fine, as the fsl_ifc_nand
>>> driver selects FSL_IFC automatically, we need the CONFIG_FSL_IFC option to
>>> be selectable for platforms using fsl_ifc with NOR flash.
>>
>> I don't understand.
>>
>> Shall I understand :
>>
>> While use of fsl_ifc driver with NAND flash is fine as the fsl_ifc_nand
>> driver selects FSL_IFC automatically, ....
>>
>> or
>>
>> ..., as the fsl_ifc_nand driver selects FSL_IFC automatically we need
>> the CONFIG_FSL_IFC option to be selectable for platforms using fsl_ifc
>> with NOR flash
>>
>>
>>
>> I'm fine with the fact that you want to be able to select it when you
>> use NOR flashes,
>
> But users are not fine... their memory won't work if they cannot choose
> it (if you meant select=choose).
Exactly. The IFC controller supports both NAND and NOR flashes. Since
commit ea0c0ad6b6eb ("memory: Enable compile testing for most of the drivers"),
it has not been possible to use IFC controller for NOR flashes without
selecting the IFC NAND driver (CONFIG_MTD_NAND_FSL_IFC), which is
obviously not how it is supposed to be.
/Esben
next prev parent reply other threads:[~2024-05-30 22:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 12:28 [PATCH v2 0/2] memory: fsl_ifc: Make FSL_IFC config visible and selectable Esben Haabendal
2024-05-28 12:28 ` [PATCH v2 1/2] " Esben Haabendal
2024-05-28 12:48 ` Miquel Raynal
2024-05-28 13:15 ` Christophe Leroy
2024-05-28 13:32 ` Krzysztof Kozlowski
2024-05-28 13:43 ` Esben Haabendal [this message]
2024-05-28 12:28 ` [PATCH v2 2/2] powerpc/configs: Update defconfig with now user-visible CONFIG_FSL_IFC Esben Haabendal
2024-05-28 13:00 ` Krzysztof Kozlowski
2024-05-28 13:33 ` Esben Haabendal
2024-05-28 13:47 ` Krzysztof Kozlowski
2024-05-29 8:14 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzjevyqc.fsf@geanix.com \
--to=esben@geanix$(echo .)com \
--cc=aneesh.kumar@kernel$(echo .)org \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=krzk@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mtd@lists$(echo .)infradead.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=miquel.raynal@bootlin$(echo .)com \
--cc=mwalle@kernel$(echo .)org \
--cc=naveen.n.rao@linux$(echo .)ibm.com \
--cc=npiggin@gmail$(echo .)com \
--cc=pratyush@kernel$(echo .)org \
--cc=richard@nod$(echo .)at \
--cc=tudor.ambarus@linaro$(echo .)org \
--cc=vigneshr@ti$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox