From: Michael Ellerman <mpe@ellerman•id.au>
To: Balbir Singh <bsingharora@gmail•com>, linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH 1/2] powerpc/xmon: support dumping software pagetables
Date: Fri, 21 Jul 2017 16:59:35 +1000 [thread overview]
Message-ID: <87k232e0mg.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20170721052406.28960-1-bsingharora@gmail.com>
Nice !
Balbir Singh <bsingharora@gmail•com> writes:
> It would be nice to be able to dump page tables in a
> particular context
>
> Example use cases
>
> Dumping PTE contents to see the keys (useful for debugging)
>
> c0000000ba48c880 c0000000bab438b0 2677 2675 T 2 protection_keys
What is that ^ ?
> 0:mon> ds c0000000ba48c880 0x7ffff7f70000
> translating tsk c0000000ba48c880, addr 7ffff7f70000
> G: 0xb95b6400 U: 0xb6334000 M: 0xb6543000 PA: 0x012c0000, PTE: 0xd4800000012c0504
Without reading the code I don't grok what G/U/M mean.
Feel free to use more than one line of output :)
> Dumping vmalloc space
>
> 0:mon> ds 0 d000000000000000
I suspect we will want to do that a lot. So I'd rather the arguments
were reversed, and the second (task) can be omitted.
So:
0:mon> ds x == translate x via init_mm
0:mon> ds x y == translate x via &y->mm
I guess it's easier for folks to find a task rather than an mm directly?
Otherwise it could take an mm not a task.
> translating tsk (null), addr d000000000000000
We should special case that to say "using kernel page tables" or similar.
> G: 0x3d450400 U: 0xbc184000 M: 0x3d460000 PA: 0x7e010000, PTE: 0xc08000007e01018e
> I did not replicate the complex code of dump_pagetable and have no support
> for bolted linear mapping, thats why I've called it software pagetable
> dumping support.
Not sure about that naming. On hash it makes sense, but not on radix or
on other platforms.
Maybe 'dv' for dump Virtual address ?
It doesn't dump a PTE, it tries to translate an address into a PTE.
cheers
next prev parent reply other threads:[~2017-07-21 6:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 5:24 [PATCH 1/2] powerpc/xmon: support dumping software pagetables Balbir Singh
2017-07-21 5:24 ` [PATCH 2/2] powerpc/xmon: revisit SPR support Balbir Singh
2017-07-21 6:59 ` Michael Ellerman [this message]
2017-07-21 8:43 ` [PATCH 1/2] powerpc/xmon: support dumping software pagetables Balbir Singh
2017-07-21 17:08 ` Ram Pai
2017-07-23 14:50 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k232e0mg.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=bsingharora@gmail$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox