From: "Aneesh Kumar K.V" <aneesh.kumar@linux•vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman•id.au>,
Anton Blanchard <anton@ozlabs•org>,
benh@kernel•crashing.org, paulus@samba•org,
acsawdey@linux•vnet.ibm.com
Cc: linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH 3/3] powerpc: Avoid load hit store when using find_linux_pte_or_hugepte()
Date: Tue, 31 May 2016 08:59:01 +0530 [thread overview]
Message-ID: <87k2ia29du.fsf@skywalker.in.ibm.com> (raw)
In-Reply-To: <1464650992.16938.8.camel@ellerman.id.au>
Michael Ellerman <mpe@ellerman•id.au> writes:
> On Sun, 2016-05-29 at 22:03 +1000, Anton Blanchard wrote:
>
>> From: Anton Blanchard <anton@samba•org>
>>
>> In many cases we disable interrupts right before calling
>> find_linux_pte_or_hugepte().
>>
>> find_linux_pte_or_hugepte() first checks interrupts are disabled
>> before calling __find_linux_pte_or_hugepte():
>>
>> if (!arch_irqs_disabled()) {
>> pr_info("%s called with irq enabled\n", __func__);
>> dump_stack();
>> }
>
> Should that be a VM_WARN_ON()?
>
VM_WARN_ON() put them inside CONFIG_DEBUG_VM. We should be able to use
WARN(!arch_irqs_disabled(), "%s called with irq enabled\n", __func__);
-aneesh
next prev parent reply other threads:[~2016-05-31 3:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-29 12:03 [PATCH 1/3] powerpc: Avoid load hit store in __giveup_fpu() and __giveup_altivec() Anton Blanchard
2016-05-29 12:03 ` [PATCH 2/3] powerpc: Avoid load hit store in setup_sigcontext() Anton Blanchard
2016-05-29 23:14 ` Michael Neuling
2016-05-29 23:23 ` Anton Blanchard
2016-06-15 12:39 ` [2/3] " Michael Ellerman
2016-05-29 12:03 ` [PATCH 3/3] powerpc: Avoid load hit store when using find_linux_pte_or_hugepte() Anton Blanchard
2016-05-30 5:17 ` Aneesh Kumar K.V
2016-05-30 23:29 ` Michael Ellerman
2016-05-31 3:29 ` Aneesh Kumar K.V [this message]
2016-05-31 4:18 ` Michael Ellerman
2016-05-31 6:52 ` Aneesh Kumar K.V
2016-06-01 3:43 ` [3/3] " Michael Ellerman
2016-06-01 5:35 ` Anton Blanchard
2016-05-30 8:15 ` [PATCH 1/3] powerpc: Avoid load hit store in __giveup_fpu() and __giveup_altivec() Gabriel Paubert
2016-05-31 10:09 ` Anton Blanchard
2016-06-01 3:06 ` Michael Ellerman
2016-06-15 12:39 ` [1/3] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2ia29du.fsf@skywalker.in.ibm.com \
--to=aneesh.kumar@linux$(echo .)vnet.ibm.com \
--cc=acsawdey@linux$(echo .)vnet.ibm.com \
--cc=anton@ozlabs$(echo .)org \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox