Subject: Re: [PATCH 3/3] powerpc: Avoid load hit store when using find_linux_pte_or_hugepte()

From: "Aneesh Kumar K.V" <[email-masked]>
Date: Tue, 31 May 2016 08:59:01 +0530

Michael Ellerman <[email-masked]> writes:

> On Sun, 2016-05-29 at 22:03 +1000, Anton Blanchard wrote:
>
>> From: Anton Blanchard <[email-masked]>
>> 
>> In many cases we disable interrupts right before calling
>> find_linux_pte_or_hugepte().
>> 
>> find_linux_pte_or_hugepte() first checks interrupts are disabled
>> before calling __find_linux_pte_or_hugepte():
>> 
>>         if (!arch_irqs_disabled()) {
>>                 pr_info("%s called with irq enabled\n", __func__);
>>                 dump_stack();
>>         }
>
> Should that be a VM_WARN_ON()?
>

VM_WARN_ON() put them inside CONFIG_DEBUG_VM. We should be able to use
WARN(!arch_irqs_disabled(), "%s called with irq enabled\n", __func__);

-aneesh