From: Esben Haabendal <esben@geanix•com>
To: Krzysztof Kozlowski <krzk@kernel•org>
Cc: Michael Walle <mwalle@kernel•org>,
Vignesh Raghavendra <vigneshr@ti•com>,
Richard Weinberger <richard@nod•at>,
linux-kernel@vger•kernel.org, Nicholas Piggin <npiggin@gmail•com>,
"Aneesh Kumar K.V" <aneesh.kumar@kernel•org>,
Tudor Ambarus <tudor.ambarus@linaro•org>,
linux-mtd@lists•infradead.org,
Miquel Raynal <miquel.raynal@bootlin•com>,
"Naveen N. Rao" <naveen.n.rao@linux•ibm.com>,
linuxppc-dev@lists•ozlabs.org,
Pratyush Yadav <pratyush@kernel•org>
Subject: Re: [PATCH v2 2/2] powerpc/configs: Update defconfig with now user-visible CONFIG_FSL_IFC
Date: Tue, 28 May 2024 15:33:04 +0200 [thread overview]
Message-ID: <87le3ukqnj.fsf@geanix.com> (raw)
In-Reply-To: <096662e8-03cf-4c13-baa0-11918cab7511@kernel.org> (Krzysztof Kozlowski's message of "Tue, 28 May 2024 15:00:57 +0200")
Krzysztof Kozlowski <krzk@kernel•org> writes:
> On 28/05/2024 14:28, Esben Haabendal wrote:
>> With CONFIG_FSL_IFC now being user-visible, and thus changed from a select
>> to depends in CONFIG_MTD_NAND_FSL_IFC, the dependencies needs to be
>> selected in config snippets.
>>
>> Signed-off-by: Esben Haabendal <esben@geanix•com>
>> ---
>> arch/powerpc/configs/85xx-hw.config | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/powerpc/configs/85xx-hw.config b/arch/powerpc/configs/85xx-hw.config
>> index 524db76f47b7..8aff83217397 100644
>> --- a/arch/powerpc/configs/85xx-hw.config
>> +++ b/arch/powerpc/configs/85xx-hw.config
>> @@ -24,6 +24,7 @@ CONFIG_FS_ENET=y
>> CONFIG_FSL_CORENET_CF=y
>> CONFIG_FSL_DMA=y
>> CONFIG_FSL_HV_MANAGER=y
>> +CONFIG_FSL_IFC=y
>
> Does not look like placed according to config order.
Correct.
> This is not alphabetically sorted, but as Kconfig creates it (make
> savedefconfig).
Are you sure about this?
It looks very much alphabetically sorted, with only two "errors"
$ diff -u 85xx-hw.config 85xx-hw.config.sorted
--- 85xx-hw.config 2024-05-28 15:05:44.665354428 +0200
+++ 85xx-hw.config.sorted 2024-05-28 15:05:56.102019081 +0200
@@ -15,8 +15,8 @@
CONFIG_DMADEVICES=y
CONFIG_E1000E=y
CONFIG_E1000=y
-CONFIG_EDAC=y
CONFIG_EDAC_MPC85XX=y
+CONFIG_EDAC=y
CONFIG_EEPROM_AT24=y
CONFIG_EEPROM_LEGACY=y
CONFIG_FB_FSL_DIU=y
@@ -71,10 +71,10 @@
CONFIG_MTD_CMDLINE_PARTS=y
CONFIG_MTD_NAND_FSL_ELBC=y
CONFIG_MTD_NAND_FSL_IFC=y
-CONFIG_MTD_RAW_NAND=y
CONFIG_MTD_PHYSMAP_OF=y
CONFIG_MTD_PHYSMAP=y
CONFIG_MTD_PLATRAM=y
+CONFIG_MTD_RAW_NAND=y
CONFIG_MTD_SPI_NOR=y
CONFIG_NETDEVICES=y
CONFIG_NVRAM=y
I don't think that this file has ever been Kconfig sorted since it was
created back in ancient times.
And as it is merged with other config snippets using merge_into_defconfig
function. I have no idea how to use savedefconfig to maintain such a snippet.
It would require doing the reverse of the merge_into_defconfig.
>> CONFIG_FSL_PQ_MDIO=y
>> CONFIG_FSL_RIO=y
>
> You also missed to update second defconfig - arm64.
Argh. I thought I checked, and it did not need any changes. But it needs
to have CONFIG_FSL_IFC=y added.
I will add that for v3.
/Esben
next prev parent reply other threads:[~2024-05-30 22:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 12:28 [PATCH v2 0/2] memory: fsl_ifc: Make FSL_IFC config visible and selectable Esben Haabendal
2024-05-28 12:28 ` [PATCH v2 1/2] " Esben Haabendal
2024-05-28 12:48 ` Miquel Raynal
2024-05-28 13:15 ` Christophe Leroy
2024-05-28 13:32 ` Krzysztof Kozlowski
2024-05-28 13:43 ` Esben Haabendal
2024-05-28 12:28 ` [PATCH v2 2/2] powerpc/configs: Update defconfig with now user-visible CONFIG_FSL_IFC Esben Haabendal
2024-05-28 13:00 ` Krzysztof Kozlowski
2024-05-28 13:33 ` Esben Haabendal [this message]
2024-05-28 13:47 ` Krzysztof Kozlowski
2024-05-29 8:14 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87le3ukqnj.fsf@geanix.com \
--to=esben@geanix$(echo .)com \
--cc=aneesh.kumar@kernel$(echo .)org \
--cc=krzk@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mtd@lists$(echo .)infradead.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=miquel.raynal@bootlin$(echo .)com \
--cc=mwalle@kernel$(echo .)org \
--cc=naveen.n.rao@linux$(echo .)ibm.com \
--cc=npiggin@gmail$(echo .)com \
--cc=pratyush@kernel$(echo .)org \
--cc=richard@nod$(echo .)at \
--cc=tudor.ambarus@linaro$(echo .)org \
--cc=vigneshr@ti$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox