From: Michael Ellerman <mpe@ellerman•id.au>
To: Srikar Dronamraju <srikar@linux•vnet.ibm.com>
Cc: linuxppc-dev@ozlabs•org, msuchanek@suse•de,
srikar@linux•vnet.ibm.com,
Stephen Rothwell <sfr@canb•auug.org.au>
Subject: Re: [PATCH] powerpc/64: Make VDSO32 track COMPAT on 64-bit
Date: Thu, 08 Oct 2020 21:53:17 +1100 [thread overview]
Message-ID: <87lfgh0z1e.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20200922075507.3fgitavbbupmi53m@linux.vnet.ibm.com>
Srikar Dronamraju <srikar@linux•vnet.ibm.com> writes:
> * Michael Ellerman <patch-notifications@ellerman•id.au> [2020-09-17 21:28:46]:
>
>> On Tue, 8 Sep 2020 22:58:50 +1000, Michael Ellerman wrote:
>> > When we added the VDSO32 kconfig symbol, which controls building of
>> > the 32-bit VDSO, we made it depend on CPU_BIG_ENDIAN (for 64-bit).
>> >
>> > That was because back then COMPAT was always enabled for 64-bit, so
>> > depending on it would have left the 32-bit VDSO always enabled, which
>> > we didn't want.
>> >
>> > [...]
>>
>> Applied to powerpc/next.
>>
>> [1/1] powerpc/64: Make VDSO32 track COMPAT on 64-bit
>> https://git.kernel.org/powerpc/c/231b232df8f67e7d37af01259c21f2a131c3911e
>>
>> cheers
>
> With this commit which is part of powerpc/next and with
> /opt/at12.0/bin/gcc --version
> gcc (GCC) 8.4.1 20191125 (Advance-Toolchain 12.0-3) [e25f27eea473]
> throws up a compile error on a witherspoon/PowerNV with CONFIG_COMPAT.
> CONFIG_COMPAT got carried from the distro config. (And looks like most
> distros seem to be having this config)
This distro config will have it because previously it couldn't be
disabled. But now that it's selectable all LE distros should disable it.
> cc1: error: _-m32_ not supported in this configuration
> make[4]: *** [arch/powerpc/kernel/vdso32/sigtramp.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> cc1: error: _-m32_ not supported in this configuration
> make[4]: *** [arch/powerpc/kernel/vdso32/gettimeofday.o] Error 1
> make[3]: *** [arch/powerpc/kernel/vdso32] Error 2
> make[3]: *** Waiting for unfinished jobs....
> make[2]: *** [arch/powerpc/kernel] Error 2
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [arch/powerpc] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [__sub-make] Error 2
>
> I don't seem to be facing with other compilers like "gcc (Ubuntu
> 7.4.0-1ubuntu1~18.04.1) 7.4.0" and I was able to disable CONFIG_COMPAT and
> proceed with the build.
It seems your compiler doesn't support building 32-bit binaries. I'm
pretty sure the kernel.org ones do, or you can just turn off COMPAT.
cheers
prev parent reply other threads:[~2020-10-08 11:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 12:58 [PATCH] powerpc/64: Make VDSO32 track COMPAT on 64-bit Michael Ellerman
2020-09-08 13:11 ` Christophe Leroy
2020-09-08 23:32 ` Michael Ellerman
2020-09-17 11:28 ` Michael Ellerman
2020-09-22 7:55 ` Srikar Dronamraju
2020-10-08 10:53 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfgh0z1e.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=msuchanek@suse$(echo .)de \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=srikar@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox