From: Stewart Smith <stewart@linux•ibm.com>
To: Nicholas Piggin <npiggin@gmail•com>, linuxppc-dev@lists•ozlabs.org
Cc: Nicholas Piggin <npiggin@gmail•com>
Subject: Re: [PATCH] powerpc/powernv: move OPAL call wrapper tracing and interrupt handling to C
Date: Wed, 27 Feb 2019 13:22:27 +1100 [thread overview]
Message-ID: <87lg22t1gc.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20190226093035.7176-1-npiggin@gmail.com>
Nicholas Piggin <npiggin@gmail•com> writes:
> The OPAL call wrapper gets interrupt disabling wrong. It disables
> interrupts just by clearing MSR[EE], which has two problems:
>
> - It doesn't call into the IRQ tracing subsystem, which means tracing
> across OPAL calls does not always notice IRQs have been disabled.
>
> - It doesn't go through the IRQ soft-mask code, which causes a minor
> bug. MSR[EE] can not be restored by saving the MSR then clearing
> MSR[EE], because a racing interrupt while soft-masked could clear
> MSR[EE] between the two steps. This can cause MSR[EE] to be
> incorrectly enabled when the OPAL call returns. Fortunately that
> should only result in another masked interrupt being taken to
> disable MSR[EE] again, but it's a bit sloppy.
>
> The existing code also saves MSR to PACA, which is not re-entrant if
> there is a nested OPAL call from different MSR contexts, which can
> happen these days with SRESET interrupts on bare metal.
>
> To fix these issues, move the tracing and IRQ handling code to C, and
> call into asm just for the low level call when everything is ready to
> go. Save the MSR on stack rather than PACA.
>
> Performance cost is kept to a minimum with a few optimisations:
>
> - The endian switch upon return is combined with the MSR restore,
> which avoids an expensive context synchronizing operation for LE
> kernels. This makes up for the additional mtmsrd to enable
> interrupts with local_irq_enable().
>
> - blr is now used to return from the opal_* functions that are called
> as C functions, to avoid link stack corruption. This requires a
> skiboot fix as well to keep the call stack balanced.
>
> A NULL call is more costly after this, (410ns->430ns on POWER9), but
> OPAL calls are generally not performance critical at this scale.
At least with this patch we can start to better measure things, and
that's a big plus. Also, When I get to start worrying about <1ms OPAL
calls, I think we can revisit optimising this path :)
--
Stewart Smith
OPAL Architect, IBM.
next prev parent reply other threads:[~2019-02-27 2:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 9:30 [PATCH] powerpc/powernv: move OPAL call wrapper tracing and interrupt handling to C Nicholas Piggin
2019-02-27 2:22 ` Stewart Smith [this message]
2019-02-28 9:21 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg22t1gc.fsf@linux.vnet.ibm.com \
--to=stewart@linux$(echo .)ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=npiggin@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox