From: "Aneesh Kumar K.V" <aneesh.kumar@linux•vnet.ibm.com>
To: ricklind@linux•vnet.ibm.com, linuxppc-dev@lists•ozlabs.org
Cc: Rick Lindsley <ricklind@linux•vnet.ibm.com>
Subject: Re: [PATCH] arch/powerpc/mm/slice: Cleanup leftover use of task_size
Date: Fri, 14 Apr 2017 01:03:40 +0530 [thread overview]
Message-ID: <87lgr4p0ff.fsf@skywalker.in.ibm.com> (raw)
In-Reply-To: <1492067567-24688-1-git-send-email-ricklind@linux.vnet.ibm.com>
ricklind@linux•vnet.ibm.com writes:
> From: Rick Lindsley <ricklind@linux•vnet.ibm.com>
>
> However, the non-radix path falls through to the old, hashed slice code
> (slice_get_unmapped_area, etc.) and these code paths still inspect
> task_size. The same attention to addr_limit made in (for example)
> radix__arch_get_unmapped_area() should also be applied to (correspondingly)
> slice_get_unmapped_area().
I missed this part earlier. I guess that should be fixed in radix code.
This came in via fbfef9027c2a7ad9277755509fdb849dbccfe8c1 (powerpc/mm:
Switch some TASK_SIZE checks to use mm_context addr_limit). That patch
needs update. When we switched from mm->task_size to
mm->context.addr_limit in latest version of the patch, we missed
updating the above correctly. I have now send a version which should
update this correctly.
https://lists.ozlabs.org/pipermail/linuxppc-dev/2017-April/156781.html
With this we use addr_limit only for slice mask optimization and addr
serach limit. All the boundary check is now based on mm->task_size.
We will later consolidate TASK_SIZE/mm->task_size/mm->context.addr_limit
-aneesh
next prev parent reply other threads:[~2017-04-13 19:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 7:12 [PATCH] arch/powerpc/mm/slice: Cleanup leftover use of task_size ricklind
2017-04-13 10:58 ` Aneesh Kumar K.V
2017-04-13 11:43 ` Rick Lindsley
2017-04-13 11:48 ` Aneesh Kumar K.V
2017-04-13 15:35 ` kbuild test robot
2017-04-14 7:16 ` Rick Lindsley
2017-04-13 19:33 ` Aneesh Kumar K.V [this message]
2017-04-14 5:31 ` Rick Lindsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgr4p0ff.fsf@skywalker.in.ibm.com \
--to=aneesh.kumar@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=ricklind@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox