From: "Aneesh Kumar K.V" <aneesh.kumar@linux•vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman•id.au>,
"Oliver O'Halloran" <oohall@gmail•com>
Cc: Balbir Singh <bsingharora@gmail•com>,
linuxppc-dev@ozlabs•org, Chris Smart <chris@distroguy•com>
Subject: Re: [PATCH] Fix "ibm,processor-radix-AP-encodings"
Date: Tue, 11 Oct 2016 13:19:53 +0530 [thread overview]
Message-ID: <87lgxvb9zy.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <87fuo35tdl.fsf@concordia.ellerman.id.au>
Michael Ellerman <mpe@ellerman•id.au> writes:
> Oliver O'Halloran <oohall@gmail•com> writes:
>
>> On Wed, Sep 28, 2016 at 12:43 PM, Aneesh Kumar K.V
>> <aneesh.kumar@linux•vnet.ibm.com> wrote:
>>> Balbir Singh <bsingharora@gmail•com> writes:
>>>
>>>> The top 3 bits of the lower order byte should contain the
>>>> AP encoding, we assume the top 3 bits of the MSB.
>>
>> Balbir, could you reword this so it says "Currently we wrongly assume
>> <blah>" or similar. The current commit message made me think you were
>> changing it to look at the top 3 bits of the MSB rather than changing
>> it look at the LSB.
>
> Yeah please reword it to describe what the current code does, why it's
> incorrect, and how we are fixing it.
>
I have an updated patch for this, which redo the AP-encoding parsing
based on spec update. Wil send it to the list once we finalize the
details
-aneesh
prev parent reply other threads:[~2016-10-11 7:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 23:13 [PATCH] Fix "ibm,processor-radix-AP-encodings" Balbir Singh
2016-09-28 2:43 ` Aneesh Kumar K.V
2016-10-10 1:06 ` Oliver O'Halloran
2016-10-11 5:47 ` Michael Ellerman
2016-10-11 7:49 ` Aneesh Kumar K.V [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgxvb9zy.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux$(echo .)vnet.ibm.com \
--cc=bsingharora@gmail$(echo .)com \
--cc=chris@distroguy$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=oohall@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox