public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@sunsite•dk>
To: David Brownell <david-b@pacbell•net>
Cc: dbrownell@users•sourceforge.net, greg@kroah•com,
	linux-usb@vger•kernel.org, linuxppc-dev@ozlabs•org,
	stern@rowland•harvard.edu
Subject: Re: [patch v8 3/4] USB: add Cypress c67x00 OTG controller HCD driver
Date: Thu, 21 Feb 2008 08:53:34 +0100	[thread overview]
Message-ID: <87mypuagox.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <200802201906.35830.david-b@pacbell.net> (David Brownell's message of "Wed\, 20 Feb 2008 19\:06\:35 -0800")

>>>>> "David" == David Brownell <david-b@pacbell•net> writes:

Hi,

 David>   +ccflags-$(CONFIG_USB_DEBUG)    += -DDEBUG

 David> It's a newish idiom, most easily applied to new code before
 David> it merges ...  :)

Ok. I'll fix that.

 David> And I realize that some of the drivers there have violated the
 David> normal "alphabetical order" convention, so maybe one big
 David> cleanup patch would be in order ... but still, I'd rather see
 David> such new options added in the right place, rather than need
 David> to see them fixed up later.

And this as well.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2008-02-21  7:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-20  9:07 [patch v8 0/4] Cypress c67x00 (EZ-Host/EZ-OTG) support Peter Korsgaard
2008-02-20  9:07 ` [patch v8 1/4] USB: add Cypress c67x00 low level interface code Peter Korsgaard
2008-02-20 16:13   ` Greg KH
2008-02-20 16:59     ` Peter Korsgaard
2008-02-20 17:40       ` Greg KH
2008-02-20  9:07 ` [patch v8 2/4] USB: add Cypress c67x00 OTG controller core driver Peter Korsgaard
2008-02-20  9:07 ` [patch v8 3/4] USB: add Cypress c67x00 OTG controller HCD driver Peter Korsgaard
2008-02-21  3:06   ` David Brownell
2008-02-21  7:53     ` Peter Korsgaard [this message]
2008-02-20  9:07 ` [patch v8 4/4] USB: add Cypress c67x00 OTG controller gadget driver Peter Korsgaard
2008-02-20 16:14 ` [patch v8 0/4] Cypress c67x00 (EZ-Host/EZ-OTG) support Greg KH
2008-02-20 17:01   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mypuagox.fsf@macbook.be.48ers.dk \
    --to=jacmet@sunsite$(echo .)dk \
    --cc=david-b@pacbell$(echo .)net \
    --cc=dbrownell@users$(echo .)sourceforge.net \
    --cc=greg@kroah$(echo .)com \
    --cc=linux-usb@vger$(echo .)kernel.org \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=stern@rowland$(echo .)harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox