Subject: Re: [RESEND PATCH] powerpc: Use str_on_off() helper in check_cache_coherency()

From: Ritesh Harjani (IBM) <[email-masked]>
Date: Mon, 23 Dec 2024 12:24:06 +0530

Thorsten Blum <[email-masked]> writes:

> Remove hard-coded strings by using the str_on_off() helper function.
>
> Signed-off-by: Thorsten Blum <[email-masked]>
> ---
>  arch/powerpc/kernel/setup-common.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
> index 6fa179448c33..f7d7a93f07fc 100644
> --- a/arch/powerpc/kernel/setup-common.c
> +++ b/arch/powerpc/kernel/setup-common.c
> @@ -834,8 +834,8 @@ static int __init check_cache_coherency(void)
>  	if (devtree_coherency != KERNEL_COHERENCY) {
>  		printk(KERN_ERR
>  			"kernel coherency:%s != device tree_coherency:%s\n",
> -			KERNEL_COHERENCY ? "on" : "off",
> -			devtree_coherency ? "on" : "off");
> +			str_on_off(KERNEL_COHERENCY),
> +			str_on_off(devtree_coherency));
>  		BUG();
>  	}

Looks good to me. Please feel free to add - 
Reviewed-by: Ritesh Harjani (IBM) <[email-masked]>

-ritesh