From: Michael Ellerman <mpe@ellerman•id.au>
To: Randy Dunlap <rdunlap@infradead•org>, linux-kernel@vger•kernel.org
Cc: "Gautham R . Shenoy" <ego@linux•vnet.ibm.com>,
"Pan, Xinhui" <Xinhui.Pan@amd•com>,
"Felix Kuehling" <Felix.Kuehling@amd•com>,
"Randy Dunlap" <rdunlap@infradead•org>,
"Nicholas Piggin" <npiggin@gmail•com>,
amd-gfx@lists•freedesktop.org,
"Alex Deucher" <alexander.deucher@amd•com>,
linuxppc-dev@lists•ozlabs.org,
"Christian König" <christian.koenig@amd•com>
Subject: Re: [PATCH] powerpc: export cpu_smallcore_map for modules
Date: Mon, 22 Aug 2022 13:40:23 +1000 [thread overview]
Message-ID: <87o7wdkkt4.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20220819210112.7924-1-rdunlap@infradead.org>
Randy Dunlap <rdunlap@infradead•org> writes:
> Fix build error when CONFIG_DRM_AMDGPU=m:
>
> ERROR: modpost: "cpu_smallcore_map" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
>
> by exporting 'cpu_smallcore_map' just as other per_cpu
> symbols are exported.
>
> drivers/gpu/drm/amd/amdkfd/kfd_device.c calls cpu_smt_mask().
> This is an inline function on powerpc which references
> cpu_smallcore_map.
>
> Fixes: 425752c63b6f ("powerpc: Detect the presence of big-cores via "ibm, thread-groups"")
> Fixes: 7bc913085765 ("drm/amdkfd: Try to schedule bottom half on same core")
That 2nd commit is not in mainline, only linux-next.
I don't mind merging this fix preemptively, but is that SHA stable?
cheers
next prev parent reply other threads:[~2022-08-22 3:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 21:01 [PATCH] powerpc: export cpu_smallcore_map for modules Randy Dunlap
2022-08-19 22:14 ` Felix Kuehling
2022-08-19 22:18 ` Alex Deucher
2022-08-22 3:40 ` Michael Ellerman [this message]
2022-08-22 3:53 ` Randy Dunlap
2022-08-22 11:30 ` Christoph Hellwig
2022-08-22 13:31 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7wdkkt4.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=Felix.Kuehling@amd$(echo .)com \
--cc=Xinhui.Pan@amd$(echo .)com \
--cc=alexander.deucher@amd$(echo .)com \
--cc=amd-gfx@lists$(echo .)freedesktop.org \
--cc=christian.koenig@amd$(echo .)com \
--cc=ego@linux$(echo .)vnet.ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=npiggin@gmail$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox