From: Michael Ellerman <mpe@ellerman•id.au>
To: Nick Desaulniers <ndesaulniers@google•com>,
"Gustavo A . R . Silva" <gustavoars@kernel•org>,
Nathan Chancellor <natechancellor@gmail•com>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail•com>
Cc: Nick Desaulniers <ndesaulniers@google•com>,
linux-kernel@vger•kernel.org, clang-built-linux@googlegroups•com,
Paul Mackerras <paulus@samba•org>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH 1/3] powerpc: boot: include compiler_attributes.h
Date: Wed, 18 Nov 2020 10:46:06 +1100 [thread overview]
Message-ID: <87o8jv35tt.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20201116043532.4032932-2-ndesaulniers@google.com>
Nick Desaulniers <ndesaulniers@google•com> writes:
> The kernel uses `-include` to include include/linux/compiler_types.h
> into all translation units (see scripts/Makefile.lib), which #includes
> compiler_attributes.h.
>
> arch/powerpc/boot/ uses different compiler flags from the rest of the
> kernel. As such, it doesn't contain the definitions from these headers,
> and redefines a few that it needs.
>
> For the purpose of enabling -Wimplicit-fallthrough for ppc, include
> compiler_types.h via `-include`.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/236
> Signed-off-by: Nick Desaulniers <ndesaulniers@google•com>
> ---
> We could just `#include "include/linux/compiler_types.h"` in the few .c
> sources used from lib/ (there are proper header guards in
> compiler_types.h).
>
> It was also noted in 6a9dc5fd6170 that we could -D__KERNEL__ and
> -include compiler_types.h like the main kernel does, though testing that
> produces a whole sea of warnings to cleanup. This approach is minimally
> invasive.
>
> arch/powerpc/boot/Makefile | 1 +
> arch/powerpc/boot/decompress.c | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
Acked-by: Michael Ellerman <mpe@ellerman•id.au>
cheers
next prev parent reply other threads:[~2020-11-17 23:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 4:35 [PATCH 0/3] PPC: Fix -Wimplicit-fallthrough for clang Nick Desaulniers
2020-11-16 4:35 ` [PATCH 1/3] powerpc: boot: include compiler_attributes.h Nick Desaulniers
2020-11-16 6:25 ` Gustavo A. R. Silva
2020-11-16 11:24 ` Miguel Ojeda
2020-11-17 3:01 ` Nathan Chancellor
2020-11-17 22:30 ` Arvind Sankar
2020-11-17 23:46 ` Michael Ellerman [this message]
2020-11-16 4:35 ` [PATCH 2/3] Revert "lib: Revert use of fallthrough pseudo-keyword in lib/" Nick Desaulniers
2020-11-16 6:26 ` Gustavo A. R. Silva
2020-11-16 11:18 ` Miguel Ojeda
2020-11-16 11:26 ` Miguel Ojeda
2020-11-16 11:49 ` kernel test robot
2020-11-17 3:02 ` Nathan Chancellor
2020-11-17 19:10 ` Nick Desaulniers
2020-11-17 22:16 ` Gustavo A. R. Silva
2020-11-17 22:28 ` Nick Desaulniers
2020-11-17 23:45 ` Gustavo A. R. Silva
2020-11-17 23:48 ` Michael Ellerman
2020-11-16 4:35 ` [PATCH 3/3] powerpc: fix -Wimplicit-fallthrough Nick Desaulniers
2020-11-16 6:28 ` Gustavo A. R. Silva
2020-11-16 11:33 ` Miguel Ojeda
2020-11-17 3:02 ` Nathan Chancellor
2020-11-17 23:46 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8jv35tt.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=clang-built-linux@googlegroups$(echo .)com \
--cc=gustavoars@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=miguel.ojeda.sandonis@gmail$(echo .)com \
--cc=natechancellor@gmail$(echo .)com \
--cc=ndesaulniers@google$(echo .)com \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox