Subject: Re: [PATCH v4 2/5] powerpc/numa: Handle extra hcall_vphn error cases

From: Nathan Lynch <[email-masked]>
Date: Wed, 02 Oct 2019 12:54:58 -0500

Srikar Dronamraju <[email-masked]> writes:
> Currently code handles H_FUNCTION, H_SUCCESS, H_HARDWARE return codes.
> However hcall_vphn can return other return codes. Now it also handles
> H_PARAMETER return code.  Also the rest return codes are handled under the
> default case.

Reviewed-by: Nathan Lynch <[email-masked]>

However:

> +	case H_PARAMETER:
> +		pr_err_ratelimited("hcall_vphn() was passed an invalid parameter. "
> +			"Disabling polling...\n");

Consider including the bad parameter value in the message?