From: Ritesh Harjani (IBM) <ritesh.list@gmail•com>
To: "Vishal Moola (Oracle)" <vishal.moola@gmail•com>, linux-mm@kvack•org
Cc: linux-kernel@vger•kernel.org,
Andrew Morton <akpm@linux-foundation•org>,
"Vishal Moola (Oracle)" <vishal.moola@gmail•com>,
Madhavan Srinivasan <maddy@linux•ibm.com>,
Michael Ellerman <mpe@ellerman•id.au>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v2 5/7] powerpc: Stop calling page_address() in free_pages()
Date: Mon, 01 Sep 2025 09:17:44 +0530 [thread overview]
Message-ID: <87plcakf4v.fsf@gmail.com> (raw)
In-Reply-To: <20250826205617.1032945-6-vishal.moola@gmail.com>
Hi Vishal,
"Vishal Moola (Oracle)" <vishal.moola@gmail•com> writes:
> free_pages() should be used when we only have a virtual address. We
> should call __free_pages() directly on our page instead.
>
> Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail•com>
> ---
> arch/powerpc/mm/book3s64/radix_pgtable.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Please also cc the respective subsystem mailing list if the changes span
in their area. In this case that would be linuxppc-dev@lists•ozlabs.org
( I did it this time )
Thanks for doing the cleanup. Yes, it makes no sense to do page_address()
here and then free_pages() doing virt_to_page() internally..
The change looks good to me. Please feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail•com>
>
> diff --git a/arch/powerpc/mm/book3s64/radix_pgtable.c b/arch/powerpc/mm/book3s64/radix_pgtable.c
> index be523e5fe9c5..73977dbabcf2 100644
> --- a/arch/powerpc/mm/book3s64/radix_pgtable.c
> +++ b/arch/powerpc/mm/book3s64/radix_pgtable.c
> @@ -780,7 +780,7 @@ static void __meminit free_vmemmap_pages(struct page *page,
> while (nr_pages--)
> free_reserved_page(page++);
> } else
> - free_pages((unsigned long)page_address(page), order);
> + __free_pages(page, order);
> }
>
> static void __meminit remove_pte_table(pte_t *pte_start, unsigned long addr,
> --
> 2.51.0
parent reply other threads:[~2025-09-01 4:00 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20250826205617.1032945-6-vishal.moola@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plcakf4v.fsf@gmail.com \
--to=ritesh.list@gmail$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maddy@linux$(echo .)ibm.com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=vishal.moola@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox