From: Michael Ellerman <mpe@ellerman•id.au>
To: Ganesh Goudar <ganeshgr@linux•ibm.com>, linuxppc-dev@lists•ozlabs.org
Cc: mahesh@linux•vnet.ibm.com, santosh@fossix•org,
Ganesh Goudar <ganeshgr@linux•ibm.com>
Subject: Re: [PATCH v3] powerpc/pseries: Handle UE event for memcpy_mcsafe
Date: Tue, 24 Mar 2020 16:27:24 +1100 [thread overview]
Message-ID: <87pnd2xqyr.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20200322160525.7624-1-ganeshgr@linux.ibm.com>
Ganesh Goudar <ganeshgr@linux•ibm.com> writes:
> If we hit UE at an instruction with a fixup entry, flag to
> ignore the event and set nip to continue execution at the
> fixup entry.
You don't explain why we would want to do that. Or what the consequences
are if we *don't* do it.
As such it's unclear if this is an important fix or just a nice-to-have.
> For powernv these changes are already made by
> commit 895e3dceeb97 ("powerpc/mce: Handle UE event for memcpy_mcsafe")
We have masses of code that supposedly abstracts the MCE logic. How did
we end up in the situation where we're having to write the same fix
twice for different platforms?
cheers
> Reviewed-by: Mahesh Salgaonkar <mahesh@linux•vnet.ibm.com>
> Reviewed-by: Santosh S <santosh@fossix•org>
> Signed-off-by: Ganesh Goudar <ganeshgr@linux•ibm.com>
> ---
> V2: Fixes a trivial checkpatch error in commit msg.
> V3: Use proper subject prefix.
> ---
> arch/powerpc/platforms/pseries/ras.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
> index 43710b69e09e..58e2483fbb1a 100644
> --- a/arch/powerpc/platforms/pseries/ras.c
> +++ b/arch/powerpc/platforms/pseries/ras.c
> @@ -10,6 +10,7 @@
> #include <linux/fs.h>
> #include <linux/reboot.h>
> #include <linux/irq_work.h>
> +#include <linux/extable.h>
>
> #include <asm/machdep.h>
> #include <asm/rtas.h>
> @@ -505,6 +506,7 @@ static int mce_handle_error(struct pt_regs *regs, struct rtas_error_log *errp)
> int initiator = rtas_error_initiator(errp);
> int severity = rtas_error_severity(errp);
> u8 error_type, err_sub_type;
> + const struct exception_table_entry *entry;
>
> if (initiator == RTAS_INITIATOR_UNKNOWN)
> mce_err.initiator = MCE_INITIATOR_UNKNOWN;
> @@ -558,6 +560,12 @@ static int mce_handle_error(struct pt_regs *regs, struct rtas_error_log *errp)
> switch (mce_log->error_type) {
> case MC_ERROR_TYPE_UE:
> mce_err.error_type = MCE_ERROR_TYPE_UE;
> + entry = search_kernel_exception_table(regs->nip);
> + if (entry) {
> + mce_err.ignore_event = true;
> + regs->nip = extable_fixup(entry);
> + disposition = RTAS_DISP_FULLY_RECOVERED;
> + }
> switch (err_sub_type) {
> case MC_ERROR_UE_IFETCH:
> mce_err.u.ue_error_type = MCE_UE_ERROR_IFETCH;
> --
> 2.17.2
next prev parent reply other threads:[~2020-03-24 5:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 16:05 [PATCH v3] powerpc/pseries: Handle UE event for memcpy_mcsafe Ganesh Goudar
2020-03-24 5:27 ` Michael Ellerman [this message]
2020-03-24 11:31 ` Ganesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnd2xqyr.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=ganeshgr@linux$(echo .)ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mahesh@linux$(echo .)vnet.ibm.com \
--cc=santosh@fossix$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox