From: Michael Ellerman <mpe@ellerman•id.au>
To: Balbir Singh <bsingharora@gmail•com>,
Anshuman Khandual <khandual@linux•vnet.ibm.com>,
linuxppc-dev@lists•ozlabs.org
Cc: aneesh.kumar@linux•vnet.ibm.com
Subject: Re: [PATCH V2] powerpc/hugetlb: Add ABI defines for supported HugeTLB page sizes
Date: Wed, 05 Apr 2017 17:09:43 +1000 [thread overview]
Message-ID: <87pogrtjns.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <1491375562.28260.33.camel@gmail.com>
Balbir Singh <bsingharora@gmail•com> writes:
> On Wed, 2017-04-05 at 10:49 +0530, Anshuman Khandual wrote:
>> diff --git a/arch/powerpc/include/uapi/asm/mman.h b/arch/powerpc/include/uapi/asm/mman.h
>> index 03c06ba..3eb788c 100644
>> --- a/arch/powerpc/include/uapi/asm/mman.h
>> +++ b/arch/powerpc/include/uapi/asm/mman.h
>> @@ -29,4 +29,9 @@
>> #define MAP_STACK 0x20000 /* give out an address that is best suited for process/thread stacks */
>> #define MAP_HUGETLB 0x40000 /* create a huge page mapping */
>>
>> +#define MAP_HUGE_2MB (21 << MAP_HUGE_SHIFT) /* 2MB HugeTLB Page */
>> +#define MAP_HUGE_16MB (24 << MAP_HUGE_SHIFT) /* 16MB HugeTLB Page */
>> +#define MAP_HUGE_1GB (30 << MAP_HUGE_SHIFT) /* 1GB HugeTLB Page */
>> +#define MAP_HUGE_16GB (34 << MAP_HUGE_SHIFT) /* 16GB HugeTLB Page */
>> +
>> #endif /* _UAPI_ASM_POWERPC_MMAN_H */
>
> We may want to call out what MMU supports what size, so that an error can
> be interpreted from the header file comments.
No don't, it can depend on what's configured in Linux and/or hypervisor
config and/or firmware and so on, so any header file comments are most
likely just going to be misleading and/or out of date.
cheers
next prev parent reply other threads:[~2017-04-05 7:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 6:03 [PATCH] powerpc/hugetlb: Add ABI defines for MAP_HUGE_16MB and MAP_HUGE_16GB Anshuman Khandual
2017-04-04 8:33 ` Aneesh Kumar K.V
2017-04-04 13:50 ` Anshuman Khandual
2017-04-05 5:19 ` [PATCH V2] powerpc/hugetlb: Add ABI defines for supported HugeTLB page sizes Anshuman Khandual
2017-04-05 6:59 ` Balbir Singh
2017-04-05 7:09 ` Michael Ellerman [this message]
2017-04-05 11:20 ` [PATCH V3] " Anshuman Khandual
2017-04-06 19:03 ` LEROY Christophe
2017-04-07 3:47 ` Anshuman Khandual
2017-04-07 3:55 ` [PATCH V4] " Anshuman Khandual
2017-04-07 13:01 ` Michael Ellerman
2017-04-07 14:58 ` Anshuman Khandual
2017-04-07 15:44 ` Paul Clarke
2017-04-08 9:19 ` Michael Ellerman
2017-04-10 22:49 ` [V4] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pogrtjns.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=aneesh.kumar@linux$(echo .)vnet.ibm.com \
--cc=bsingharora@gmail$(echo .)com \
--cc=khandual@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox