From: Peter Korsgaard <jacmet@sunsite•dk>
To: galak@kernel•crashing.org, linuxppc-dev@ozlabs•org
Subject: [PATCH] fsl_spi devices should use mode "cpu" or "qe"
Date: Wed, 03 Oct 2007 17:43:00 +0200 [thread overview]
Message-ID: <87przwxkzf.fsf@macbook.be.48ers.dk> (raw)
According to booting-without-of.txt, fsl_spi mode should be either
"cpu" or "qe", not "cpu-qe".
Signed-off-by: Peter Korsgaard <jacmet@sunsite•dk>
---
arch/powerpc/boot/dts/mpc832x_rdb.dts | 2 +-
arch/powerpc/sysdev/fsl_soc.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/boot/dts/mpc832x_rdb.dts b/arch/powerpc/boot/dts/mpc832x_rdb.dts
index 388c8a7..a5158d5 100644
--- a/arch/powerpc/boot/dts/mpc832x_rdb.dts
+++ b/arch/powerpc/boot/dts/mpc832x_rdb.dts
@@ -175,7 +175,7 @@
reg = <4c0 40>;
interrupts = <2>;
interrupt-parent = <&qeic>;
- mode = "cpu-qe";
+ mode = "qe";
};
spi@500 {
diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/fsl_soc.c
index c765d7a..a57fe56 100644
--- a/arch/powerpc/sysdev/fsl_soc.c
+++ b/arch/powerpc/sysdev/fsl_soc.c
@@ -1253,7 +1253,7 @@ int __init fsl_spi_init(struct spi_board_info *board_infos,
pdata.bus_num = *(u32 *)prop;
prop = of_get_property(np, "mode", NULL);
- if (prop && !strcmp(prop, "cpu-qe"))
+ if (prop && !strcmp(prop, "qe"))
pdata.qe_mode = 1;
for (j = 0; j < num_board_infos; j++) {
--
1.5.3.2
--
Bye, Peter Korsgaard
next reply other threads:[~2007-10-03 15:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 15:43 Peter Korsgaard [this message]
2007-10-03 15:51 ` [PATCH] fsl_spi devices should use mode "cpu" or "qe" Kumar Gala
2007-10-03 15:56 ` Joakim Tjernlund
2007-10-03 15:56 ` Peter Korsgaard
2007-10-03 15:57 ` Grant Likely
2007-10-03 16:08 ` Kumar Gala
2007-10-03 16:29 ` [PATCH] fsl_spi: mode should be "cpu-qe" instead of "qe" Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87przwxkzf.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite$(echo .)dk \
--cc=galak@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox