From: Michael Ellerman <mpe@ellerman•id.au>
To: Athira Rajeev <atrajeev@linux•vnet.ibm.com>,
acme@kernel•org, jolsa@kernel•org, disgoel@linux•vnet.ibm.com
Cc: irogers@google•com, maddy@linux•vnet.ibm.com,
rnsastry@linux•ibm.com, kjain@linux•ibm.com,
linux-perf-users@vger•kernel.org, linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH V2 2/2] tools/perf/tests: Fix session topology test to skip the test in guest environment
Date: Fri, 06 May 2022 12:40:38 +1000 [thread overview]
Message-ID: <87r157tmc9.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20220505094000.58220-3-atrajeev@linux.vnet.ibm.com>
Athira Rajeev <atrajeev@linux•vnet.ibm.com> writes:
> The session topology test fails in powerpc pSeries platform.
> Test logs:
> <<>>
> Session topology : FAILED!
> <<>>
>
> This testcases tests cpu topology by checking the core_id and
> socket_id stored in perf_env from perf session. The data from
> perf session is compared with the cpu topology information
> from "/sys/devices/system/cpu/cpuX/topology" like core_id,
> physical_package_id. In case of virtual environment, detail
> like physical_package_id is restricted to be exposed. Hence
> physical_package_id is set to -1. The testcase fails on such
> platforms since socket_id can't be fetched from topology info.
>
> Skip the testcase in powerpc for pSeries. Use the utility
> function "cpuinfo_field" to check platform from /proc/cpuinfo.
I don't think that's the right way to fix it.
If we ever had a "pseries" machine that did expose physical_package_id
then this test would continue to skip, even when it could succeed.
So if physical_package_id being -1 is the problem then you should skip
the test based on that.
cheers
next prev parent reply other threads:[~2022-05-06 2:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 9:39 [PATCH V2 0/2] Fix session topology test for powerpc and add utility function to get cpuinfo entries Athira Rajeev
2022-05-05 9:39 ` [PATCH V2 1/2] tools/perf: Add utility function to read /proc/cpuinfo for any field Athira Rajeev
2022-05-05 17:24 ` Arnaldo Carvalho de Melo
2022-05-06 9:33 ` Athira Rajeev
2022-05-10 13:38 ` Athira Rajeev
2022-05-10 17:08 ` Arnaldo Carvalho de Melo
2022-05-05 9:40 ` [PATCH V2 2/2] tools/perf/tests: Fix session topology test to skip the test in guest environment Athira Rajeev
2022-05-06 2:40 ` Michael Ellerman [this message]
2022-05-05 10:49 ` [PATCH V2 0/2] Fix session topology test for powerpc and add utility function to get cpuinfo entries Disha Goel
2022-05-05 10:52 ` kajoljain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r157tmc9.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=acme@kernel$(echo .)org \
--cc=atrajeev@linux$(echo .)vnet.ibm.com \
--cc=disgoel@linux$(echo .)vnet.ibm.com \
--cc=irogers@google$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=kjain@linux$(echo .)ibm.com \
--cc=linux-perf-users@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maddy@linux$(echo .)vnet.ibm.com \
--cc=rnsastry@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox