From: Michael Ellerman <mpe@ellerman•id.au>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Stephen Rothwell <sfr@canb•auug.org.au>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 2/3] powerpc/mm: Rename hpte_init_lpar() & put fallback in a header
Date: Mon, 25 Jul 2016 20:36:12 +1000 [thread overview]
Message-ID: <87r3aidmxv.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <1469440186.5978.35.camel@kernel.crashing.org>
Benjamin Herrenschmidt <benh@kernel•crashing.org> writes:
> On Mon, 2016-07-25 at 15:33 +1000, Michael Ellerman wrote:
>> When we detect a PS3 we set both PS3_LV1 and LPAR at the same time,
>> so
>> there should be no way they can get out of sync, other than due to a
>> bug in the code.
>
> I thought I had changed PS3 to no longer set LPAR ?
Nope:
FW_FEATURE_PS3_POSSIBLE = FW_FEATURE_LPAR | FW_FEATURE_PS3_LV1,
...
#ifdef CONFIG_PPC_PS3
/* Identify PS3 firmware */
if (of_flat_dt_is_compatible(of_get_flat_dt_root(), "sony,ps3"))
powerpc_firmware_features |= FW_FEATURE_PS3_POSSIBLE;
#endif
> I like having a flag that basically says PAPR and that's pretty much
> what LPAR is, in fact I think I've been using it elsewhere with that
> meaning
That would be nice, but these look fishy at least:
arch/powerpc/platforms/cell/spu_manage.c: if (!firmware_has_feature(FW_FEATURE_LPAR))
arch/powerpc/platforms/cell/spu_manage.c: if (!firmware_has_feature(FW_FEATURE_LPAR)) {
arch/powerpc/platforms/cell/spu_manage.c: if (!firmware_has_feature(FW_FEATURE_LPAR))
arch/powerpc/platforms/pasemi/iommu.c: !firmware_has_feature(FW_FEATURE_LPAR)) {
drivers/net/ethernet/pasemi/pasemi_mac.c: return firmware_has_feature(FW_FEATURE_LPAR);
cheers
next prev parent reply other threads:[~2016-07-25 10:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 2:57 [PATCH 1/3] powerpc/mm: Fix build break due when PPC_NATIVE=n Michael Ellerman
2016-07-25 2:57 ` [PATCH 2/3] powerpc/mm: Rename hpte_init_lpar() & put fallback in a header Michael Ellerman
2016-07-25 4:13 ` Stephen Rothwell
2016-07-25 4:42 ` Benjamin Herrenschmidt
2016-07-25 5:33 ` Michael Ellerman
2016-07-25 9:49 ` Benjamin Herrenschmidt
2016-07-25 10:36 ` Michael Ellerman [this message]
2016-07-25 12:11 ` Benjamin Herrenschmidt
2016-07-27 0:27 ` Michael Ellerman
2016-07-25 2:57 ` [PATCH 3/3] powerpc/mm: Drop unused externs for hpte_init_beat[_v3]() Michael Ellerman
2016-07-27 14:32 ` [3/3] " Michael Ellerman
2016-07-25 4:03 ` [PATCH 1/3] powerpc/mm: Fix build break due when PPC_NATIVE=n Stephen Rothwell
2016-07-25 6:17 ` Michael Ellerman
2016-07-25 10:39 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3aidmxv.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox