From: Michael Ellerman <mpe@ellerman•id.au>
To: Christoph Hellwig <hch@lst•de>
Cc: Jens Axboe <axboe@kernel•dk>,
"Martin K. Petersen" <martin.petersen@oracle•com>,
"Linux regression tracking \(Thorsten Leemhuis\)"
<regressions@leemhuis•info>, John Garry <john.g.garry@oracle•com>,
linux-block@vger•kernel.org, Niklas Cassel <cassel@kernel•org>,
Damien Le Moal <dlemoal@kernel•org>,
linux-ide@vger•kernel.org, linux-scsi@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org, Christoph Hellwig <hch@lst•de>,
Guenter Roeck <linux@roeck-us•net>,
Linux kernel regressions list <regressions@lists•linux.dev>
Subject: Re: [PATCH 04/23] scsi: initialize scsi midlayer limits before allocating the queue
Date: Fri, 31 May 2024 18:06:25 +1000 [thread overview]
Message-ID: <87sexy2yny.fsf@mail.lhotse> (raw)
In-Reply-To: <20240531060827.GA17723@lst.de>
Christoph Hellwig <hch@lst•de> writes:
> On Fri, May 31, 2024 at 12:28:21AM +1000, Michael Ellerman wrote:
>> No that's wrong. The actual hardware page size is 4K, but
>> CONFIG_PAGE_SIZE and PAGE_SHIFT etc. is 64K.
>>
>> So at least for this user the driver used to work with 64K pages, and
>> now doesn't.
>
> Which suggested that the communicated max_hw_sectors is wrong, and
> previously we were saved by the block layer increasing it to
> PAGE_SIZE after a warning. Should we just increment it to 64k?
It looks like that user actually only has the CDROM hanging off
pata_macio, so it's possible it has been broken previously and they
didn't notice. I'll see if they can confirm the CDROM has been working
up until now.
I can test the CDROM on my G5 next week.
cheers
next prev parent reply other threads:[~2024-05-31 8:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <08beb913-f525-49e2-8ef2-f62e9d466e53@roeck-us.net>
2024-05-20 15:15 ` [PATCH 04/23] scsi: initialize scsi midlayer limits before allocating the queue Christoph Hellwig
2024-05-29 14:36 ` Linux regression tracking (Thorsten Leemhuis)
2024-05-30 6:25 ` Thorsten Leemhuis
2024-05-30 12:46 ` Michael Ellerman
2024-05-30 14:28 ` Michael Ellerman
2024-05-31 6:08 ` Christoph Hellwig
2024-05-31 8:06 ` Michael Ellerman [this message]
2024-06-05 12:37 ` Michael Ellerman
2024-06-06 5:54 ` Christoph Hellwig
2024-06-06 8:21 ` John Garry
2024-06-06 12:33 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sexy2yny.fsf@mail.lhotse \
--to=mpe@ellerman$(echo .)id.au \
--cc=axboe@kernel$(echo .)dk \
--cc=cassel@kernel$(echo .)org \
--cc=dlemoal@kernel$(echo .)org \
--cc=hch@lst$(echo .)de \
--cc=john.g.garry@oracle$(echo .)com \
--cc=linux-block@vger$(echo .)kernel.org \
--cc=linux-ide@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linux@roeck-us$(echo .)net \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=martin.petersen@oracle$(echo .)com \
--cc=regressions@leemhuis$(echo .)info \
--cc=regressions@lists$(echo .)linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox