From: "Aneesh Kumar K.V" <aneesh.kumar@linux•ibm.com>
To: Nicholas Piggin <npiggin@gmail•com>, linuxppc-dev@lists•ozlabs.org
Cc: "Aneesh Kumar K . V" <aneesh.kumar@linux•vnet.ibm.com>,
Nicholas Piggin <npiggin@gmail•com>
Subject: Re: [PATCH] powerpc/64s/radix: tlb do not flush on page size when fullmm
Date: Wed, 25 Jul 2018 19:47:29 +0530 [thread overview]
Message-ID: <87sh47o0w6.fsf@linux.ibm.com> (raw)
In-Reply-To: <20180725135806.29648-1-npiggin@gmail.com>
Nicholas Piggin <npiggin@gmail•com> writes:
> When the mm is being torn down there will be a full PID flush so
> there is no need to flush the TLB on page size changes.
and that tlb flush is PID flush since tlb->fulmm is set? So this avoids
multiple PID tlb flush.
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux•ibm.com>
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail•com>
> ---
> arch/powerpc/include/asm/tlb.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/powerpc/include/asm/tlb.h b/arch/powerpc/include/asm/tlb.h
> index 5d3107f2b014..d1b3dc4a6a0a 100644
> --- a/arch/powerpc/include/asm/tlb.h
> +++ b/arch/powerpc/include/asm/tlb.h
> @@ -84,6 +84,9 @@ static inline void __tlb_remove_tlb_entry(struct mmu_gather *tlb, pte_t *ptep,
> static inline void tlb_remove_check_page_size_change(struct mmu_gather *tlb,
> unsigned int page_size)
> {
> + if (tlb->fullmm)
> + return;
> +
> if (!tlb->page_size)
> tlb->page_size = page_size;
> else if (tlb->page_size != page_size) {
> --
> 2.17.0
next prev parent reply other threads:[~2018-07-25 14:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 13:58 [PATCH] powerpc/64s/radix: tlb do not flush on page size when fullmm Nicholas Piggin
2018-07-25 14:17 ` Aneesh Kumar K.V [this message]
2018-08-08 14:25 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh47o0w6.fsf@linux.ibm.com \
--to=aneesh.kumar@linux$(echo .)ibm.com \
--cc=aneesh.kumar@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=npiggin@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox