From: Michael Ellerman <mpe@ellerman•id.au>
To: Laurent Dufour <ldufour@linux•vnet.ibm.com>,
Christopher Covington <cov@codeaurora•org>,
criu@openvz•org, Will Deacon <will.deacon@arm•com>,
linux-mm@kvack•org
Cc: Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
Subject: Re: [RFC v2 6/7] mm/powerpc: Use generic VDSO remap and unmap functions
Date: Tue, 08 Nov 2016 10:51:56 +1100 [thread overview]
Message-ID: <87shr2lug3.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <e974b3a6-2a80-a416-7583-4b0644e8a613@linux.vnet.ibm.com>
Laurent Dufour <ldufour@linux•vnet.ibm.com> writes:
> On 04/11/2016 05:59, Michael Ellerman wrote:
>> Christopher Covington <cov@codeaurora•org> writes:
>>
>>> The PowerPC VDSO remap and unmap code was copied to a generic location,
>>> only modifying the variable name expected in mm->context (vdso instead of
>>> vdso_base) to match most other architectures. Having adopted this generic
>>> naming, drop the code in arch/powerpc and use the generic version.
>>>
>>> Signed-off-by: Christopher Covington <cov@codeaurora•org>
>>> ---
>>> arch/powerpc/Kconfig | 1 +
>>> arch/powerpc/include/asm/Kbuild | 1 +
>>> arch/powerpc/include/asm/mm-arch-hooks.h | 28 -------------------------
>>> arch/powerpc/include/asm/mmu_context.h | 35 +-------------------------------
>>> 4 files changed, 3 insertions(+), 62 deletions(-)
>>> delete mode 100644 arch/powerpc/include/asm/mm-arch-hooks.h
>>
>> This looks OK.
>>
>> Have you tested it on powerpc? I could but I don't know how to actually
>> trigger these paths, I assume I need a CRIU setup?
>
> FWIW, tested on ppc64le using a sample test process moving its VDSO and
> then catching a signal on 4.9-rc4 and using CRIU on top of 4.8 with
> sightly changes to due minor upstream changes.
>
> Reviewed-by: Laurent Dufour <ldufour@linux•vnet.ibm.com>
> Tested-by: Laurent Dufour <ldufour@linux•vnet.ibm.com>
Thanks, in that case:
Acked-by: Michael Ellerman <mpe@ellerman•id.au>
cheers
prev parent reply other threads:[~2016-11-07 23:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161101171101.24704-1-cov@codeaurora.org>
2016-11-01 17:10 ` [RFC v2 5/7] powerpc: Rename context.vdso_base to context.vdso Christopher Covington
2016-11-04 4:58 ` Michael Ellerman
2016-11-04 20:13 ` Will Deacon
2016-11-07 8:01 ` Michael Ellerman
2016-11-01 17:11 ` [RFC v2 6/7] mm/powerpc: Use generic VDSO remap and unmap functions Christopher Covington
2016-11-04 4:59 ` Michael Ellerman
2016-11-07 20:20 ` Laurent Dufour
2016-11-07 23:51 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shr2lug3.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=benh@kernel$(echo .)crashing.org \
--cc=cov@codeaurora$(echo .)org \
--cc=criu@openvz$(echo .)org \
--cc=ldufour@linux$(echo .)vnet.ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
--cc=will.deacon@arm$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox