From: Nikunj A Dadhania <nikunj@linux•vnet.ibm.com>
To: Thomas Huth <thuth@linux•vnet.ibm.com>,
Alexey Kardashevskiy <aik@ozlabs•ru>
Cc: linuxppc-dev@lists•ozlabs.org,
David Gibson <david@gibson•dropbear.id.au>
Subject: Re: [PATCH SLOF] pci-properties: Remove redundant call to device-type
Date: Wed, 11 Mar 2015 14:04:59 +0530 [thread overview]
Message-ID: <87sidcc4p8.fsf@abhimanyu.in.ibm.com> (raw)
In-Reply-To: <20150311085030.43ac4fac@oc7435384737.ibm.com>
Thomas Huth <thuth@linux•vnet.ibm.com> writes:
> On Wed, 11 Mar 2015 17:26:32 +1100
> Alexey Kardashevskiy <aik@ozlabs•ru> wrote:
>
>> At the moment SLOF adds a "device_type" property automatically for
>> every single PCI device based on its class even if there is no SLOF
>> driver for such a device. OF1275 says that "device_type" is for
>> implemented interfaces only. A side effect of this is virtio-balloon
>> getting device_type=="memory" while it should not have.
>>
>> This removes automatic call to device-type from the common PCI code.
>> Since now, we rely on existing SLOF PCI drivers to call device-type if
>> needed. virtio-blk/net, e1000, ohci/ehci/xhci do this. virtio-scsi
>> does not create the property for itself but disks on its bus do.
>> virtio-ballon won't get the device_type property as there is no driver
>> for it.
>
Looks good to me.
> Sounds very reasonable, but I think there are a couple of other things
> you could/should check:
>
> - Graphic cards should get the "display" device_type ... I guess that's
> missing now?
No, its being set as "display"
> - pci bus nodes (like bridges) should get the "pci" device_type
> according to the Open Firmware PCI binding, is this still the case?
Yes
> - Seems like there are some other devices with device_type property
> where SLOF does not provide an implemented interface, like in
> slof/fs/usb/dev-mouse.fs ... should these be revised, too?
./slof/fs/usb/dev-mouse.fs:s" mouse" device-type
Regards,
Nikunj
prev parent reply other threads:[~2015-03-11 8:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 6:26 [PATCH SLOF] pci-properties: Remove redundant call to device-type Alexey Kardashevskiy
2015-03-11 7:50 ` Thomas Huth
2015-03-11 8:21 ` Benjamin Herrenschmidt
2015-03-11 8:30 ` Thomas Huth
2015-03-11 9:13 ` Alexey Kardashevskiy
2015-03-11 8:34 ` Nikunj A Dadhania [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sidcc4p8.fsf@abhimanyu.in.ibm.com \
--to=nikunj@linux$(echo .)vnet.ibm.com \
--cc=aik@ozlabs$(echo .)ru \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=thuth@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox