From: Takashi Iwai <tiwai@suse•de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix•de>
Cc: "Andrew Lunn" <andrew@lunn•ch>,
"Heiko Stuebner" <heiko@sntech•de>,
"Xiubo Li" <Xiubo.Lee@gmail•com>,
"Moises Cardona" <moisesmcardona@gmail•com>,
"Jaroslav Kysela" <perex@perex•cz>,
"Liam Girdwood" <liam.r.girdwood@linux•intel.com>,
"Muralidhar Reddy" <muralidhar.reddy@intel•com>,
"Sylwester Nawrocki" <s.nawrocki@samsung•com>,
"Gongjun Song" <gongjun.song@intel•com>,
"Gaosheng Cui" <cuigaosheng1@huawei•com>,
"Marek Szyprowski" <m.szyprowski@samsung•com>,
"Samuel Holland" <samuel@sholland•org>,
"Ranjani Sridharan" <ranjani.sridharan@linux•intel.com>,
"NXP Linux Team" <linux-imx@nxp•com>,
"Olivier Moysan" <olivier.moysan@foss•st.com>,
"Martin Povišer" <povik+lin@cutebit•org>,
"Linus Walleij" <linus.walleij@linaro•org>,
"Sascha Hauer" <s.hauer@pengutronix•de>,
"Nicholas Piggin" <npiggin@gmail•com>,
"James Schulman" <james.schulman@cirrus•com>,
"syed saba kareem" <syed.sabakareem@amd•com>,
"Thomas Gleixner" <tglx@linutronix•de>,
linux-omap@vger•kernel.org,
"Alexander Sverdlin" <alexander.sverdlin@gmail•com>,
"Allison Randal" <allison@lohutok•net>,
"Scott Branden" <sbranden@broadcom•com>,
"Geoff Levand" <geoff@infradead•org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation•org>,
"Zhang Qilong" <zhangqilong3@huawei•com>,
linux-stm32@st-md-mailman•stormreply.com,
"Shang XiaoJing" <shangxiaojing@huawei•com>,
"Masami Hiramatsu" <mhiramat@kernel•org>,
kernel@pengutronix•de, "Li Chen" <lchen@ambarella•com>,
"Claudiu Beznea" <claudiu.beznea@microchip•com>,
"Jarkko Nikula" <jarkko.nikula@bitmer•com>,
"Alexandre Belloni" <alexandre.belloni@bootlin•com>,
"Lucas Tanure" <tanureal@opensource•cirrus.com>,
"David Rhodes" <david.rhodes@cirrus•com>,
"Max Filippov" <jcmvbkbc@gmail•com>,
"Thierry Reding" <thierry.reding@gmail•com>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro•org>,
"Mario Limonciello" <mario.limonciello@amd•com>,
"Liang He" <windhl@126•com>, "Ban Tao" <fengzheng923@gmail•com>,
"Hezi Shahmoon" <hezi@marvell•com>,
"Chunyan Zhang" <zhang.lyra@gmail•com>,
YueHaibing <yuehaibing@huawei•com>
Subject: Re: [PATCH 000/173] ALSA/ASoC: Convert to platform remove callback returning void
Date: Thu, 16 Mar 2023 10:32:08 +0100 [thread overview]
Message-ID: <87ttylhwiv.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de>
On Wed, 15 Mar 2023 16:04:52 +0100,
Uwe Kleine-König wrote:
>
> Hello,
>
> this series adapts the platform drivers below sound/ to use the .remove_new()
> callback. Compared to the traditional .remove() callback .remove_new() returns
> no value. This is a good thing because the driver core doesn't (and cannot)
> cope for errors during remove. The only effect of a non-zero return value in
> .remove() is that the driver core emits a warning. The device is removed anyhow
> and an early return from .remove() usually yields a resource leak.
>
> By changing the remove callback to return void driver authors cannot
> reasonably assume any more that there is some kind of cleanup later.
>
> The first two patches simplify a driver each to return zero unconditionally,
> and then all drivers are trivially converted to .remove_new().
>
> There are nearly no interdependencies in this patch set---only 1 <- 11 and
> 2 <- 16. So even if some individual problems are found (I don't expect that),
> the other patches can (and from my POV should) still be applied.
>
> Best regards
> Uwe
>
> Uwe Kleine-König (173):
(snip)
For the whole series,
Acked-by: Takashi Iwai <tiwai@suse•de>
thanks,
Takashi
next prev parent reply other threads:[~2023-03-16 23:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 15:04 [PATCH 000/173] ALSA/ASoC: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-15 15:05 ` [PATCH 010/173] ALSA: ppc/powermac: " Uwe Kleine-König
2023-03-15 15:05 ` [PATCH 064/173] ASoC: fsl: fsl_asrc: " Uwe Kleine-König
2023-03-15 15:05 ` [PATCH 065/173] ASoC: fsl: fsl_aud2htx: " Uwe Kleine-König
2023-03-15 15:05 ` [PATCH 066/173] ASoC: fsl: fsl_audmix: " Uwe Kleine-König
2023-03-15 15:05 ` [PATCH 067/173] ASoC: fsl: fsl_dma: " Uwe Kleine-König
2023-03-15 15:06 ` [PATCH 068/173] ASoC: fsl: fsl_easrc: " Uwe Kleine-König
2023-03-15 15:06 ` [PATCH 069/173] ASoC: fsl: fsl_esai: " Uwe Kleine-König
2023-03-15 15:06 ` [PATCH 070/173] ASoC: fsl: fsl_mqs: " Uwe Kleine-König
2023-03-15 15:06 ` [PATCH 071/173] ASoC: fsl: fsl_rpmsg: " Uwe Kleine-König
2023-03-15 15:06 ` [PATCH 072/173] ASoC: fsl: fsl_sai: " Uwe Kleine-König
2023-03-15 15:06 ` [PATCH 073/173] ASoC: fsl: fsl_spdif: " Uwe Kleine-König
2023-03-15 15:06 ` [PATCH 074/173] ASoC: fsl: fsl_ssi: " Uwe Kleine-König
2023-03-15 15:06 ` [PATCH 075/173] ASoC: fsl: fsl_xcvr: " Uwe Kleine-König
2023-03-15 15:06 ` [PATCH 076/173] ASoC: fsl: imx-audmux: " Uwe Kleine-König
2023-03-15 15:06 ` [PATCH 077/173] ASoC: fsl: imx-pcm-rpmsg: " Uwe Kleine-König
2023-03-15 15:06 ` [PATCH 078/173] ASoC: fsl: imx-sgtl5000: " Uwe Kleine-König
2023-03-15 15:06 ` [PATCH 081/173] ASoC: fsl: mpc8610_hpcd: " Uwe Kleine-König
2023-03-16 9:32 ` Takashi Iwai [this message]
2023-03-21 16:50 ` (subset) [PATCH 000/173] ALSA/ASoC: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttylhwiv.wl-tiwai@suse.de \
--to=tiwai@suse$(echo .)de \
--cc=Xiubo.Lee@gmail$(echo .)com \
--cc=alexander.sverdlin@gmail$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=allison@lohutok$(echo .)net \
--cc=andrew@lunn$(echo .)ch \
--cc=claudiu.beznea@microchip$(echo .)com \
--cc=cuigaosheng1@huawei$(echo .)com \
--cc=david.rhodes@cirrus$(echo .)com \
--cc=fengzheng923@gmail$(echo .)com \
--cc=geoff@infradead$(echo .)org \
--cc=gongjun.song@intel$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=heiko@sntech$(echo .)de \
--cc=hezi@marvell$(echo .)com \
--cc=james.schulman@cirrus$(echo .)com \
--cc=jarkko.nikula@bitmer$(echo .)com \
--cc=jcmvbkbc@gmail$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=lchen@ambarella$(echo .)com \
--cc=liam.r.girdwood@linux$(echo .)intel.com \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=mario.limonciello@amd$(echo .)com \
--cc=mhiramat@kernel$(echo .)org \
--cc=moisesmcardona@gmail$(echo .)com \
--cc=muralidhar.reddy@intel$(echo .)com \
--cc=npiggin@gmail$(echo .)com \
--cc=olivier.moysan@foss$(echo .)st.com \
--cc=perex@perex$(echo .)cz \
--cc=povik+lin@cutebit$(echo .)org \
--cc=ranjani.sridharan@linux$(echo .)intel.com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=s.nawrocki@samsung$(echo .)com \
--cc=samuel@sholland$(echo .)org \
--cc=sbranden@broadcom$(echo .)com \
--cc=shangxiaojing@huawei$(echo .)com \
--cc=srinivas.kandagatla@linaro$(echo .)org \
--cc=syed.sabakareem@amd$(echo .)com \
--cc=tanureal@opensource$(echo .)cirrus.com \
--cc=tglx@linutronix$(echo .)de \
--cc=thierry.reding@gmail$(echo .)com \
--cc=u.kleine-koenig@pengutronix$(echo .)de \
--cc=windhl@126$(echo .)com \
--cc=yuehaibing@huawei$(echo .)com \
--cc=zhang.lyra@gmail$(echo .)com \
--cc=zhangqilong3@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox