From: Michael Ellerman <mpe@ellerman•id.au>
To: Alexey Spirkov <AlexeiS@astrosoft•ru>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
"linuxppc-dev\@lists.ozlabs.org" <linuxppc-dev@lists•ozlabs.org>
Cc: "trivial\@kernel.org" <trivial@kernel•org>,
"andrew\@ncrmnt.org" <andrew@ncrmnt•org>
Subject: Re: [PATCH] Adds __init annotation at mmu_init_secondary func
Date: Fri, 27 Jul 2018 20:47:40 +1000 [thread overview]
Message-ID: <87tvolrm43.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <AM5PR03MB28499BE4A0B6200F7DA83835C92B0@AM5PR03MB2849.eurprd03.prod.outlook.com>
Alexey Spirkov <AlexeiS@astrosoft•ru> writes:
> mmu_init_secondary function called at initialization sequence
> but it misses __init annotation. As result modpost warning is generated.
> Some building systems sensitive to such kind of warnings.
What warning are you seeing?
AFAICS it's not called from, nor does it call, any __init code.
So I'm a bit confused.
cheers
> diff --git a/arch/powerpc/mm/44x_mmu.c b/arch/powerpc/mm/44x_mmu.c
> index 82b1ff7..12d9251 100644
> --- a/arch/powerpc/mm/44x_mmu.c
> +++ b/arch/powerpc/mm/44x_mmu.c
> @@ -229,7 +229,7 @@ void setup_initial_memory_limit(phys_addr_t first_memblock_base,
> }
>
> #ifdef CONFIG_SMP
> -void mmu_init_secondary(int cpu)
> +void __init mmu_init_secondary(int cpu)
> {
> unsigned long addr;
> unsigned long memstart = memstart_addr & ~(PPC_PIN_SIZE - 1);
> --
> 2.9.5
next prev parent reply other threads:[~2018-07-27 10:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 12:52 [PATCH] Adds __init annotation at mmu_init_secondary func Alexey Spirkov
2018-07-27 10:47 ` Michael Ellerman [this message]
2018-07-27 10:57 ` Alexey Spirkov
2018-07-30 6:57 ` Michael Ellerman
2018-08-01 5:24 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvolrm43.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=AlexeiS@astrosoft$(echo .)ru \
--cc=andrew@ncrmnt$(echo .)org \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
--cc=trivial@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox