From: "Aneesh Kumar K.V" <aneesh.kumar@linux•vnet.ibm.com>
To: Gavin Shan <gwshan@linux•vnet.ibm.com>, linuxppc-dev@lists•ozlabs.org
Cc: mpe@ellerman•id.au, Gavin Shan <gwshan@linux•vnet.ibm.com>
Subject: Re: [PATCH] powerpc/mm: Fix typo in set_pte_at()
Date: Mon, 06 Feb 2017 08:03:57 +0530 [thread overview]
Message-ID: <87tw88gi96.fsf@skywalker.in.ibm.com> (raw)
In-Reply-To: <1486340396-24609-1-git-send-email-gwshan@linux.vnet.ibm.com>
Gavin Shan <gwshan@linux•vnet.ibm.com> writes:
> This fixes the typo about the _PAGE_PTE in set_pte_at() by changing
> "tryint" to "trying to".
>
> Fixes: 6a119eae942 ("powerpc/mm: Add a _PAGE_PTE bit")
I guess this is not needed. We add that when we want to hint whether the
patch needs backporting.
> Signed-off-by: Gavin Shan <gwshan@linux•vnet.ibm.com>
> ---
> arch/powerpc/mm/pgtable.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c
> index cb39c8b..a03ff3d 100644
> --- a/arch/powerpc/mm/pgtable.c
> +++ b/arch/powerpc/mm/pgtable.c
> @@ -193,9 +193,7 @@ void set_pte_at(struct mm_struct *mm, unsigned long addr, pte_t *ptep,
> */
> VM_WARN_ON(pte_present(*ptep) && !pte_protnone(*ptep));
>
> - /*
> - * Add the pte bit when tryint set a pte
> - */
> + /* Add the pte bit when trying to set a pte */
> pte = __pte(pte_val(pte) | _PAGE_PTE);
>
> /* Note: mm->context.id might not yet have been assigned as
> --
> 2.7.4
next prev parent reply other threads:[~2017-02-06 2:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 0:19 [PATCH] powerpc/mm: Fix typo in set_pte_at() Gavin Shan
2017-02-06 2:33 ` Aneesh Kumar K.V [this message]
2017-02-06 4:51 ` Gavin Shan
2017-02-08 3:17 ` Gavin Shan
2017-02-08 9:22 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tw88gi96.fsf@skywalker.in.ibm.com \
--to=aneesh.kumar@linux$(echo .)vnet.ibm.com \
--cc=gwshan@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox