public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman•id.au>
To: Andrew Donnellan <andrew.donnellan@au1•ibm.com>,
	linuxppc-dev@lists•ozlabs.org
Cc: stewart@linux•vnet.ibm.com
Subject: Re: [PATCH RFC] powerpc/powernv: sysfs entry to force full IPL reboot
Date: Tue, 22 Nov 2016 21:27:46 +1100	[thread overview]
Message-ID: <87twazvmfx.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20161122092258.32514-1-andrew.donnellan@au1.ibm.com>

Andrew Donnellan <andrew.donnellan@au1•ibm.com> writes:

> skiboot now supports "fast reboot", a reboot procedure where skiboot
> reinitialises hardware and loads a new kernel without re-IPLing the
> machine. At present, fast reboot support is still experimental and is not
> enabled by default, however it is intended that it will be enabled by
> default in a near-future release.
>
> There may be some circumstances where the user wants to force a full IPL
> reboot rather than using fast reboot. Add support for the
> OPAL_REBOOT_FULL_IPL reboot type, enabled by writing 1 to
> /sys/firmware/opal/force_full_ipl_reboot. On versions of skiboot that
> implement the OPAL_REBOOT_FULL_IPL reboot type, this will force an IPL. On
> versions that do not, print an error message on reboot and proceed with a
> regular reboot (which could be a full IPL or a fast reboot).

Hi Andrew,

Can I suggest:
 - Fix OPAL
 - Fix OPAL
 - Fix OPAL

...

Oh OK, it's firmware :D

There's existing logic in kernel/reboot.c to handle a reboot= command
line parameter, which can set the reboot_mode, so my preference would be
that we use that.

Currently we completely ignore the reboot_mode, so there's no backward
compatibility issue.

It looks like the default is REBOOT_COLD, whatever that means. So I
think we could define that on powernv REBOOT_HARD means "do a full IPL".

Or we could use "force", which already exists, though I can't quite see
what that actually means on x86.

cheers

  reply	other threads:[~2016-11-22 10:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-22  9:22 [PATCH RFC] powerpc/powernv: sysfs entry to force full IPL reboot Andrew Donnellan
2016-11-22 10:27 ` Michael Ellerman [this message]
2016-11-23  1:37   ` Andrew Donnellan
2016-11-23  2:33     ` Andrew Donnellan
2016-11-23  3:19       ` Michael Ellerman
2016-12-23  4:19         ` Stewart Smith
2016-12-23  4:20 ` Stewart Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87twazvmfx.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman$(echo .)id.au \
    --cc=andrew.donnellan@au1$(echo .)ibm.com \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    --cc=stewart@linux$(echo .)vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox