Subject: Re: [PATCH 1/2] powerpc: mm: use macro PGTABLE_EADDR_SIZE instead of digital

From: "Aneesh Kumar K.V" <[email-masked]>
Date: Wed, 30 Apr 2014 11:00:39 +0530

Liu Ping Fan <[email-masked]> writes:

> In case of extending the eaddr in future, use this macro
> PGTABLE_EADDR_SIZE to ease the maintenance of the code.
>
> Signed-off-by: Liu Ping Fan <[email-masked]>

Reviewed-by: Aneesh Kumar K.V <[email-masked]>

> ---
>  arch/powerpc/mm/slb_low.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/mm/slb_low.S b/arch/powerpc/mm/slb_low.S
> index 17aa6df..e0b3cf4 100644
> --- a/arch/powerpc/mm/slb_low.S
> +++ b/arch/powerpc/mm/slb_low.S
> @@ -35,7 +35,7 @@ _GLOBAL(slb_allocate_realmode)
>  	 * check for bad kernel/user address
>  	 * (ea & ~REGION_MASK) >= PGTABLE_RANGE
>  	 */
> -	rldicr. r9,r3,4,(63 - 46 - 4)
> +	rldicr. r9,r3,4,(63 - PGTABLE_EADDR_SIZE - 4)
>  	bne-	8f
>
>  	srdi	r9,r3,60		/* get region */
> -- 
> 1.8.1.4
>
> _______________________________________________
> Linuxppc-dev mailing list
> [email-masked]
> https://lists.ozlabs.org/listinfo/linuxppc-dev