From: Michael Ellerman <mpe@ellerman•id.au>
To: Christian Lamparter <chunkeey@gmail•com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [1/2] powerpc/4xx/ocm: Fix phys_addr_t printf warnings
Date: Sat, 12 Jan 2019 00:10:11 +1100 [thread overview]
Message-ID: <87va2ve3ws.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <1833028.0eqVQs4dtG@debian64>
Christian Lamparter <chunkeey@gmail•com> writes:
> On Tuesday, January 8, 2019 10:54:28 AM CET Michael Ellerman wrote:
>> Christian Lamparter <chunkeey@gmail•com> writes:
...
>> diff --git a/arch/powerpc/platforms/4xx/ocm.c b/arch/powerpc/platforms/4xx/ocm.c
>> index a1aaa1569d7c..f0e488d97567 100644
>> --- a/arch/powerpc/platforms/4xx/ocm.c
>> +++ b/arch/powerpc/platforms/4xx/ocm.c
>> @@ -237,12 +237,12 @@ static int ocm_debugfs_show(struct seq_file *m, void *v)
>> continue;
>>
>> seq_printf(m, "PPC4XX OCM : %d\n", ocm->index);
>> - seq_printf(m, "PhysAddr : %pa[p]\n", &(ocm->phys));
>> + seq_printf(m, "PhysAddr : %pa\n", &(ocm->phys));
>> seq_printf(m, "MemTotal : %d Bytes\n", ocm->memtotal);
>> seq_printf(m, "MemTotal(NC) : %d Bytes\n", ocm->nc.memtotal);
>> seq_printf(m, "MemTotal(C) : %d Bytes\n\n", ocm->c.memtotal);
>>
>> - seq_printf(m, "NC.PhysAddr : %pa[p]\n", &(ocm->nc.phys));
>> + seq_printf(m, "NC.PhysAddr : %pa\n", &(ocm->nc.phys));
>> seq_printf(m, "NC.VirtAddr : 0x%p\n", ocm->nc.virt);
>> seq_printf(m, "NC.MemTotal : %d Bytes\n", ocm->nc.memtotal);
>> seq_printf(m, "NC.MemFree : %d Bytes\n", ocm->nc.memfree);
>> @@ -252,7 +252,7 @@ static int ocm_debugfs_show(struct seq_file *m, void *v)
>> blk->size, blk->owner);
>> }
>>
>> - seq_printf(m, "\nC.PhysAddr : %pa[p]\n", &(ocm->c.phys));
>> + seq_printf(m, "\nC.PhysAddr : %pa\n", &(ocm->c.phys));
>> seq_printf(m, "C.VirtAddr : 0x%p\n", ocm->c.virt);
>> seq_printf(m, "C.MemTotal : %d Bytes\n", ocm->c.memtotal);
>> seq_printf(m, "C.MemFree : %d Bytes\n", ocm->c.memfree);
>
> Ok, with the patch applied it now looks like:
>
> |root@mbl:/sys/kernel/debug/ppc4xx_ocm# cat info
> |PPC4XX OCM : 1
> |PhysAddr : 0x0000000400040000
> |MemTotal : 32768 Bytes
> |MemTotal(NC) : 32768 Bytes
> |MemTotal(C) : 0 Bytes
> |
> |NC.PhysAddr : 0x0000000400040000
> |NC.VirtAddr : 0x54f5bce2
> |NC.MemTotal : 32768 Bytes
> |NC.MemFree : 32768 Bytes
> |
> |C.PhysAddr : 0x0000000000000000
> |C.VirtAddr : 0x (null)
> |C.MemTotal : 0 Bytes
> |C.MemFree : 0 Bytes
>
> ... just as expected. ;)
Thanks.
cheers
prev parent reply other threads:[~2019-01-11 13:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 3:56 [PATCH 1/2] powerpc/4xx/ocm: Fix phys_addr_t printf warnings Michael Ellerman
2019-01-01 3:56 ` [PATCH 2/2] powerpc/configs: Add PPC4xx_OCM to ppc40x_defconfig Michael Ellerman
2019-01-01 16:52 ` [PATCH 1/2] powerpc/4xx/ocm: Fix phys_addr_t printf warnings LEROY Christophe
2019-01-02 11:12 ` Michael Ellerman
2019-01-02 11:31 ` [1/2] " Michael Ellerman
2019-01-04 20:46 ` Christian Lamparter
2019-01-08 9:54 ` Michael Ellerman
2019-01-08 17:21 ` Christian Lamparter
2019-01-11 13:10 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87va2ve3ws.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=chunkeey@gmail$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox