From: Michael Ellerman <mpe@ellerman•id.au>
To: Daniel Vetter <daniel@ffwll•ch>,
Christophe LEROY <christophe.leroy@c-s•fr>
Cc: Pavel Machek <pavel@ucw•cz>,
elfring@users•sourceforge.net,
kernel list <linux-kernel@vger•kernel.org>,
vgupta@synopsys•com, linux@armlinux•org.uk, oleg@redhat•com,
catalin.marinas@arm•com, will.deacon@arm•com, paulus@ozlabs•org,
benh@kernel•crashing.org, ard.biesheuvel@linaro•org,
tglx@linutronix•de, mingo@redhat•com, hpa@zytor•com,
x86@kernel•org, scott.bauer@intel•com,
jonathan.derrick@intel•com, axboe@kernel•dk,
daniel.lezcano@linaro•org, maxime.ripard@free-electrons•com,
wens@csie•org, alexander.deucher@amd•com,
christian.koenig@amd•com, David1.Zhou@amd•com, airlied@linux•ie,
robdclark@gmail•com, joro@8bytes•org, shli@kernel•org,
shawnguo@kernel•org, kernel@pengutronix•de,
fabio.estevam@nxp•com, akpm@linux-foundation•org,
Alexey.Brodkin@synopsys•com, mhocko@suse•com, vbabka@suse•cz,
Vladislav.Zakharov@synopsys•com, noamca@mellanox•com,
yamada.masahiro@socionext•com, sboyd@codeaurora•org,
viresh.kumar@linaro•org, linus.walleij@linaro•org,
heiko@sntech•de, aik@ozlabs•ru, ruscur@russell•cc,
david@gibson•dropbear.id.au, fbarrat@linux•vnet.ibm.com,
alistair@popple•id.au, robh@kernel•org, joe@perches•com,
harry.wentland@amd•com, tony.cheng@amd•com, Wenjing.Liu@amd•com,
airlied@redhat•com, Ding.Wang@amd•com, sylvia.tsai@amd•com,
hersenxs.wu@amd•com, Rex.Zhu@amd•com, JinHuiEric.Huang@amd•com,
dan.carpenter@oracle•com, architt@codeaurora•org,
daniel.vetter@ffwll•ch, narmstrong@baylibre•com,
ville.syrjala@linux•intel.com, jcrouse@codeaurora•org,
aishpant@gmail•com, noralf@tronnes•org, andresx7@gmail•com,
Monk.Liu@amd•com, nicolai.haehnle@amd•com,
Andrey.Grodzovsky@amd•com, linux-snps-arc@lists•infradead.org,
linux-arm-kernel@lists•infradead.org, kvm-ppc@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org, linux-efi@vger•kernel.org,
linux-block@vger•kernel.org, amd-gfx@lists•freedesktop.org,
dri-devel@lists•freedesktop.org, linux-arm-msm@vger•kernel.org,
freedreno@lists•freedesktop.org,
iommu@lists•linux-foundation.org, linux-raid@vger•kernel.org
Subject: Re: [PATCH] fix double ;;s in code
Date: Tue, 20 Feb 2018 17:19:31 +1100 [thread overview]
Message-ID: <87vaesrxn0.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20180219154135.GV22199@phenom.ffwll.local>
Daniel Vetter <daniel@ffwll•ch> writes:
> On Sun, Feb 18, 2018 at 11:00:56AM +0100, Christophe LEROY wrote:
>> Le 17/02/2018 =C3=A0 22:19, Pavel Machek a =C3=A9crit=C2=A0:
>> >=20
>> > Fix double ;;'s in code.
>> >=20
>> > Signed-off-by: Pavel Machek <pavel@ucw•cz>
>>=20
>> A summary of the files modified on top of the patch would help understand
>> the impact.
>>=20
>> A maybe there should be one patch by area, eg one for each arch specific
>> modif and one for drivers/ and one for block/ ?
>
> Yeah, pls split this into one patch per area, with a suitable patch
> subject prefix. Look at git log of each file to get a feeling for what's
> the standard in each area.
This part is actually pretty annoying.
I hacked up a script (below) which seems to do a reasonable job in most
cases.
For this patch it gives:
$ for f in $(git ls-files -m); do ./guess-prefix.py $f; done
ARC:=20
ARC:=20
ARM:=20
arm64: ptrace:=20
KVM: PPC:=20
powerpc/powernv:
x86/efi:
block/sed-opal:
clocksource: mips-gic:=20
clocksource/drivers/sun5i:
drm/amd/display:
drm/amd/powerplay:
drm/msm/mdp5:
drm:=20
iommu/vt-d:
md:=20
soc: imx: gpc:=20
I think those are correct except for:
- "drm:" for "drivers/gpu/drm/scheduler" which has only a single commit.
- "md:" for "drivers/md/raid1.c" which is tricked by inconsistent
usage of "md: raid1:" and "md/raid1:".
But that seems like a reasonable hit rate.
Another approach would be to have a file that defines for each subsystem
what the preferred style is, but that is likely to be a PITA to
maintain.
cheers
#!/usr/bin/python3
import sys
import re
from subprocess import check_output
from collections import Counter
if len(sys.argv) !=3D 2:
print('Usage: %s <path>' % sys.argv[0], file=3Dsys.stderr)
sys.exit(1)
fname =3D sys.argv[1]
cmd =3D ['git', 'log', '--format=3D%s', '-n', '100', fname]
output =3D check_output(cmd).decode('utf-8')
ignore =3D ['License', 'Merge']
# Ordered list of patterns
patterns =3D [
# Common style "foo/bar/baz: Fix the foo"
re.compile('^([\w\-_]+: )+'),
# Less common "foo bar baz: Fix the foo"
re.compile('^([\w\-_]+:? )+: ')
]
words =3D []
for line in output.splitlines():
prefix =3D line.split()[0]
for patt in patterns:
match =3D patt.search(line)
if match:
prefix =3D match.group(0)
break
if prefix in ignore:
continue
words.append(prefix)
# Warn if we didn't find many examples
if len(words) < 5:
print("Warning: only found %d previous commits to guess from for" % len=
(words),
fname, file=3Dsys.stderr)
counts =3D Counter(words)
print(counts.most_common(1)[0][0])
next prev parent reply other threads:[~2018-02-20 6:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-17 21:19 [PATCH] fix double ;;s in code Pavel Machek
2018-02-18 10:00 ` Christophe LEROY
2018-02-19 15:41 ` Daniel Vetter
2018-02-19 19:33 ` Pavel Machek
2018-02-20 1:25 ` Rob Clark
2018-02-20 8:03 ` Jani Nikula
2018-02-20 16:34 ` Alex Deucher
2018-02-20 23:47 ` Andrew Morton
2018-02-20 6:19 ` Michael Ellerman [this message]
2018-02-20 16:41 ` Joe Perches
2018-02-20 5:33 ` Vineet Gupta
2018-02-22 9:09 ` Shawn Guo
2018-02-24 8:52 ` Pavel Machek
2018-02-24 8:56 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vaesrxn0.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=Alexey.Brodkin@synopsys$(echo .)com \
--cc=Andrey.Grodzovsky@amd$(echo .)com \
--cc=David1.Zhou@amd$(echo .)com \
--cc=Ding.Wang@amd$(echo .)com \
--cc=JinHuiEric.Huang@amd$(echo .)com \
--cc=Monk.Liu@amd$(echo .)com \
--cc=Rex.Zhu@amd$(echo .)com \
--cc=Vladislav.Zakharov@synopsys$(echo .)com \
--cc=Wenjing.Liu@amd$(echo .)com \
--cc=aik@ozlabs$(echo .)ru \
--cc=airlied@linux$(echo .)ie \
--cc=airlied@redhat$(echo .)com \
--cc=aishpant@gmail$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alexander.deucher@amd$(echo .)com \
--cc=alistair@popple$(echo .)id.au \
--cc=amd-gfx@lists$(echo .)freedesktop.org \
--cc=andresx7@gmail$(echo .)com \
--cc=architt@codeaurora$(echo .)org \
--cc=ard.biesheuvel@linaro$(echo .)org \
--cc=axboe@kernel$(echo .)dk \
--cc=benh@kernel$(echo .)crashing.org \
--cc=catalin.marinas@arm$(echo .)com \
--cc=christian.koenig@amd$(echo .)com \
--cc=christophe.leroy@c-s$(echo .)fr \
--cc=dan.carpenter@oracle$(echo .)com \
--cc=daniel.lezcano@linaro$(echo .)org \
--cc=daniel.vetter@ffwll$(echo .)ch \
--cc=daniel@ffwll$(echo .)ch \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=elfring@users$(echo .)sourceforge.net \
--cc=fabio.estevam@nxp$(echo .)com \
--cc=fbarrat@linux$(echo .)vnet.ibm.com \
--cc=freedreno@lists$(echo .)freedesktop.org \
--cc=harry.wentland@amd$(echo .)com \
--cc=heiko@sntech$(echo .)de \
--cc=hersenxs.wu@amd$(echo .)com \
--cc=hpa@zytor$(echo .)com \
--cc=iommu@lists$(echo .)linux-foundation.org \
--cc=jcrouse@codeaurora$(echo .)org \
--cc=joe@perches$(echo .)com \
--cc=jonathan.derrick@intel$(echo .)com \
--cc=joro@8bytes$(echo .)org \
--cc=kernel@pengutronix$(echo .)de \
--cc=kvm-ppc@vger$(echo .)kernel.org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-block@vger$(echo .)kernel.org \
--cc=linux-efi@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-raid@vger$(echo .)kernel.org \
--cc=linux-snps-arc@lists$(echo .)infradead.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maxime.ripard@free-electrons$(echo .)com \
--cc=mhocko@suse$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=narmstrong@baylibre$(echo .)com \
--cc=nicolai.haehnle@amd$(echo .)com \
--cc=noamca@mellanox$(echo .)com \
--cc=noralf@tronnes$(echo .)org \
--cc=oleg@redhat$(echo .)com \
--cc=paulus@ozlabs$(echo .)org \
--cc=pavel@ucw$(echo .)cz \
--cc=robdclark@gmail$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=ruscur@russell$(echo .)cc \
--cc=sboyd@codeaurora$(echo .)org \
--cc=scott.bauer@intel$(echo .)com \
--cc=shawnguo@kernel$(echo .)org \
--cc=shli@kernel$(echo .)org \
--cc=sylvia.tsai@amd$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=tony.cheng@amd$(echo .)com \
--cc=vbabka@suse$(echo .)cz \
--cc=vgupta@synopsys$(echo .)com \
--cc=ville.syrjala@linux$(echo .)intel.com \
--cc=viresh.kumar@linaro$(echo .)org \
--cc=wens@csie$(echo .)org \
--cc=will.deacon@arm$(echo .)com \
--cc=x86@kernel$(echo .)org \
--cc=yamada.masahiro@socionext$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox