From: "Aneesh Kumar K.V" <aneesh.kumar@linux•vnet.ibm.com>
To: Balbir Singh <bsingharora@gmail•com>,
Michael Ellerman <mpe@ellerman•id.au>,
Michael Neuling <mikey@neuling•org>
Cc: linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v2] powerpc/mm/radix: Invalidate ERAT on tlbiel for POWER9 DD1
Date: Wed, 16 Nov 2016 16:58:58 +0530 [thread overview]
Message-ID: <87vavnll39.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <426fb387-a925-04f3-1027-7e347e2885bb@gmail.com>
Balbir Singh <bsingharora@gmail•com> writes:
> On 16/11/16 21:51, Michael Ellerman wrote:
>> Michael Neuling <mikey@neuling•org> writes:
>>> diff --git a/arch/powerpc/mm/tlb-radix.c b/arch/powerpc/mm/tlb-radix.c
>>> index bda8c43be7..4a19cdd8a0 100644
>>> --- a/arch/powerpc/mm/tlb-radix.c
>>> +++ b/arch/powerpc/mm/tlb-radix.c
>>> @@ -50,6 +50,9 @@ static inline void _tlbiel_pid(unsigned long pid, unsigned long ric)
>>> for (set = 0; set < POWER9_TLB_SETS_RADIX ; set++) {
>>> __tlbiel_pid(pid, set, ric);
>>> }
>>> + if (cpu_has_feature(CPU_FTR_POWER9_DD1))
>>> + asm volatile(PPC_SLBIA(0x7)
>>> + : : :"memory");
>>
>> Ah of course I'll use slbia to invalidate the ERAT.
>>
>> How about we do:
>>
>> #define PPC_INVALIDATE_ERAT PPC_SLBIA(0x7)
>>
>
> While you are at it, could you also add a TODO
> to use a HCALL when LPCR_GTSE is not set
> (when running in guest mode)
In what config we use that ? With radix we always run with GTSE = 1 and
with hash we don't use tlbiel in guest.
-aneesh
prev parent reply other threads:[~2016-11-16 11:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 5:23 [PATCH v2] powerpc/mm/radix: Invalidate ERAT on tlbiel for POWER9 DD1 Michael Neuling
2016-11-16 10:51 ` Michael Ellerman
2016-11-16 11:02 ` Balbir Singh
2016-11-16 11:28 ` Aneesh Kumar K.V [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vavnll39.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux$(echo .)vnet.ibm.com \
--cc=bsingharora@gmail$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mikey@neuling$(echo .)org \
--cc=mpe@ellerman$(echo .)id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox