Subject: Re: [PATCH 7/7] [POWERPC] Xilinx: Uartlite: Section type fixups

From: Peter Korsgaard <[email-masked]>
Date: Wed, 09 Jan 2008 12:24:48 +0100

>>>>> "Stephen" == Stephen Neuendorffer <[email-masked]> writes:

 Stephen> All the __devexit functions are now appropriately tagged.  This fixes
 Stephen> some ppc link warnings.

You forgot to add __devexit_p(ulite_remove) in ulite_platform_driver,
otherwise:

Acked-by: Peter Korsgaard <[email-masked]>

 Stephen> Signed-off-by: Stephen Neuendorffer <[email-masked]>
 Stephen> ---
 Stephen>  drivers/serial/uartlite.c |    4 ++--
 Stephen>  1 files changed, 2 insertions(+), 2 deletions(-)

 Stephen> diff --git a/drivers/serial/uartlite.c b/drivers/serial/uartlite.c
 Stephen> index 02c2d89..ecd5540 100644
 Stephen> --- a/drivers/serial/uartlite.c
 Stephen> +++ b/drivers/serial/uartlite.c
 Stephen> @@ -594,7 +594,7 @@ static int __devinit ulite_assign(struct device *dev, int id, u32 base, int irq)
 Stephen>   *
 Stephen>   * @dev: pointer to device structure
 Stephen>   */
 Stephen> -static int __devinit ulite_release(struct device *dev)
 Stephen> +static int __devexit ulite_release(struct device *dev)
 Stephen>  {
 Stephen>  	struct uart_port *port = dev_get_drvdata(dev);
 Stephen>  	int rc = 0;
 Stephen> @@ -627,7 +627,7 @@ static int __devinit ulite_probe(struct platform_device *pdev)
 Stephen>  	return ulite_assign(&pdev->dev, pdev->id, res->start, res2->start);
 Stephen>  }
 
 Stephen> -static int ulite_remove(struct platform_device *pdev)
 Stephen> +static int __devexit ulite_remove(struct platform_device *pdev)
 Stephen>  {
 Stephen>  	return ulite_release(&pdev->dev);
 Stephen>  }
 Stephen> -- 
 Stephen> 1.5.3.4-dirty

 Stephen> _______________________________________________
 Stephen> Linuxppc-dev mailing list
 Stephen> [email-masked]
 Stephen> https://ozlabs.org/mailman/listinfo/linuxppc-dev

-- 
Bye, Peter Korsgaard