From: Peter Korsgaard <jacmet@sunsite•dk>
To: glikely@gmail•com
Cc: linuxppc-embedded <linuxppc-embedded@ozlabs•org>
Subject: Re: [PATCH 2/2] Add support for MEMEC 2VP30-FF1152 eval board with simple FPGA design
Date: Tue, 20 Sep 2005 21:50:35 +0200 [thread overview]
Message-ID: <87vf0vselw.fsf@p4.48ers.dk> (raw)
In-Reply-To: <528646bc05091000377417dc16@mail.gmail.com> (Grant Likely's message of "Sat, 10 Sep 2005 01:37:39 -0600")
>>>>> "Grant" == Grant Likely <glikely@gmail•com> writes:
Hi,
Grant> Here is an example port to another V2PRO based board. This
Grant> patch is for information only and is NOT suitable for
Grant> submission up to mainline
Ok, I still have a little comment though..
Grant> diff --git a/arch/ppc/boot/simple/embed_config.c
Grant> b/arch/ppc/boot/simple/embed_config.c
Grant> --- a/arch/ppc/boot/simple/embed_config.c
Grant> +++ b/arch/ppc/boot/simple/embed_config.c
Grant> @@ -745,7 +745,7 @@ embed_config(bd_t **bdp)
Grant> }
Grant> #endif /* WILLOW */
Grant>
Grant> -#ifdef CONFIG_XILINX_ML300
Grant> +#ifdef CONFIG_VIRTEX_II_PRO
Grant> void
Grant> embed_config(bd_t ** bdp)
Grant> {
Please don't force all V2P boards to use the same embed_config. I'm
using RedBoot on a V2P board, which provides a ready to go bd_t that I
can directly use.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2005-09-20 19:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-10 7:37 [PATCH 2/2] Add support for MEMEC 2VP30-FF1152 eval board with simple FPGA design Grant Likely
2005-09-20 19:50 ` Peter Korsgaard [this message]
2005-09-20 20:35 ` Grant Likely
2005-09-21 6:13 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vf0vselw.fsf@p4.48ers.dk \
--to=jacmet@sunsite$(echo .)dk \
--cc=glikely@gmail$(echo .)com \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox