From: Peter Korsgaard <jacmet@sunsite•dk>
To: glikely@gmail•com
Cc: linuxppc-embedded <linuxppc-embedded@ozlabs•org>
Subject: Re: [PATCH 1/2] Move Virtex-II Pro / ML300 port over to the platform bus.
Date: Tue, 20 Sep 2005 08:26:28 +0200 [thread overview]
Message-ID: <87vf0wp84r.fsf@p4.48ers.dk> (raw)
In-Reply-To: <528646bc050910003630c25dca@mail.gmail.com> (Grant Likely's message of "Sat, 10 Sep 2005 01:36:28 -0600")
>>>>> " " == Grant Likely <glikely@gmail•com> writes:
Hi,
> This is a large patch that moves the ML300 to the platform bus.
> It also isolates most of the linux tree from changes to the
> xparameters.h file. Ultimately, the goal is to move everything
> over to the flattened device tree for telling the kernel about
> devices. That way xparameters.h can go away entirely for the
> kernel proper. (Isolated to the bootloader)
Great!
> Comments are appreciated.
Here you go..
> diff --git a/arch/ppc/platforms/4xx/xilinx_ml300_devices.c
...
> +struct plat_serial8250_port serial_platform_data[] = {
> +#ifdef XPAR_OPB_UART16550_0_BASEADDR
> + {
> + .mapbase = XPAR_OPB_UART16550_0_BASEADDR + 3,
> + .irq = XPAR_DCR_INTC_0_OPB_UART16550_0_IP2INTC_IRPT_INTR,
> + .iotype = UPIO_MEM,
> + .uartclk = XPAR_XUARTNS550_CLOCK_HZ,
> + .flags = UPF_BOOT_AUTOCONF,
> + .regshift = 2,
> + },
> +#endif
> +#ifdef XPAR_OPB_UART16550_1_BASEADDR
> + {
> + .mapbase = XPAR_OPB_UART16550_1_BASEADDR + 3,
You forgot the offset of 0x1000 (did you mean
XPAR_UARTNS550_0_BASEADDR) ?
> diff --git a/arch/ppc/platforms/4xx/xparameters/xparameters.h
...
> + /* zImage serial port definitions */
> + #define SERIAL_PORT_DFNS { \
> + .baud_base = XPAR_XUARTNS550_CLOCK_HZ/16, \
> + .irq = XPAR_DCR_INTC_0_OPB_UART16550_0_IP2INTC_IRPT_INTR, \
> + .flags = ASYNC_BOOT_AUTOCONF, \
> + .iomem_base = (u8 *)XPAR_OPB_UART16550_0_BASEADDR + 3, \
And again.
Otherwise it looks good.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2005-09-20 6:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-10 7:36 [PATCH 1/2] Move Virtex-II Pro / ML300 port over to the platform bus Grant Likely
2005-09-20 6:26 ` Peter Korsgaard [this message]
[not found] ` <528646bc05091923462e07de0c@mail.gmail.com>
[not found] ` <9305ca410512050558o4778824as5a5b24a9bfeccc75@mail.gmail.com>
2005-12-05 16:52 ` Grant Likely
[not found] ` <9305ca410512050858s4c8f640dja71c3945cdb5762f@mail.gmail.com>
2005-12-05 17:40 ` Grant Likely
2005-12-05 20:52 ` Peter Korsgaard
[not found] <689CB232690D8D4E97DA6C76DA098E6C017395E1@XCO-EXCHVS1.xlnx.xilinx.com>
2005-12-06 21:12 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vf0wp84r.fsf@p4.48ers.dk \
--to=jacmet@sunsite$(echo .)dk \
--cc=glikely@gmail$(echo .)com \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox