Subject: Re: [PATCH 1/2] Move Virtex-II Pro / ML300 port over to the platform bus.

From: Peter Korsgaard <[email-masked]>
Date: Tue, 20 Sep 2005 08:26:28 +0200

>>>>> " " == Grant Likely <[email-masked]> writes:

Hi,

 > This is a large patch that moves the ML300 to the platform bus.
 > It also isolates most of the linux tree from changes to the
 > xparameters.h file.  Ultimately, the goal is to move everything
 > over to the flattened device tree for telling the kernel about
 > devices.  That way xparameters.h can go away entirely for the
 > kernel proper.  (Isolated to the bootloader)

Great!

> Comments are appreciated.

Here you go..

> diff --git a/arch/ppc/platforms/4xx/xilinx_ml300_devices.c
...
> +struct plat_serial8250_port serial_platform_data[] = {
> +#ifdef XPAR_OPB_UART16550_0_BASEADDR
> +	{
> +		.mapbase  = XPAR_OPB_UART16550_0_BASEADDR + 3,
> +		.irq	  = XPAR_DCR_INTC_0_OPB_UART16550_0_IP2INTC_IRPT_INTR,
> +		.iotype	  = UPIO_MEM,
> +		.uartclk  = XPAR_XUARTNS550_CLOCK_HZ,
> +		.flags	  = UPF_BOOT_AUTOCONF,
> +		.regshift = 2,
> +	},
> +#endif
> +#ifdef XPAR_OPB_UART16550_1_BASEADDR
> +	{
> +		.mapbase  = XPAR_OPB_UART16550_1_BASEADDR + 3,

You forgot the offset of 0x1000 (did you mean
XPAR_UARTNS550_0_BASEADDR) ?

> diff --git a/arch/ppc/platforms/4xx/xparameters/xparameters.h
...

> +  /* zImage serial port definitions */
> +  #define SERIAL_PORT_DFNS {                                            \
> +        .baud_base       = XPAR_XUARTNS550_CLOCK_HZ/16,                 \
> +        .irq             = XPAR_DCR_INTC_0_OPB_UART16550_0_IP2INTC_IRPT_INTR, \
> +        .flags           = ASYNC_BOOT_AUTOCONF,                         \
> +        .iomem_base      = (u8 *)XPAR_OPB_UART16550_0_BASEADDR + 3,     \

And again.

Otherwise it looks good.

-- 
Bye, Peter Korsgaard