Subject: Re: [PATCHv11 2/4] genirq: Provide a snapshot mechanism for interrupt statistics

From: Thomas Gleixner <[email-masked]>
Date: Mon, 04 Mar 2024 15:24:39 +0100

On Mon, Mar 04 2024 at 20:00, Bitao Hu wrote:
>> +# Snapshot for interrupt statistics
>> +config GENERIC_IRQ_STAT_SNAPSHOT
>> +	bool
>> +
>>   # Support forced irq threading
>>   config IRQ_FORCED_THREADING
>>          bool
>
> I think we should follow Douglas's suggestion by making
> "config GENERIC_IRQ_STAT_SNAPSHOT" automatically selectable by
> "config SOFTLOCKUP_DETECTOR_INTR_STORM". This can prevent users
> from inadvertently disabling "config GENERIC_IRQ_STAT_SNAPSHOT"
> while enabling "config SOFTLOCKUP_DETECTOR_INTR_STORM".

The above is not even configurable by the user. It's only selectable by
some other config option.

> +# Snapshot for interrupt statistics
> +config GENERIC_IRQ_STAT_SNAPSHOT
> +       bool
> +       help
> +
> +         Say Y here to enable the kernel to provide a snapshot mechanism
> +         for interrupt statistics.

That makes is visible which is pointless because it's only relevant when
there is an actual user.

Thanks,

        tglx