public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Thiago Jung Bauermann <bauerman@linux•ibm.com>
To: Ram Pai <linuxram@us•ibm.com>
Cc: mpe@ellerman•id.au, linuxppc-dev@lists•ozlabs.org,
	hbabu@us•ibm.com, mhocko@kernel•org, bauerman@linux•vnet.ibm.com,
	Ulrich.Weigand@de•ibm.com, fweimer@redhat•com, msuchanek@suse•de
Subject: Re: [PATCH 2/2] powerpc/ptrace-pkeys: execute-permission on keys are disabled by default
Date: Tue, 03 Jul 2018 00:30:53 -0300	[thread overview]
Message-ID: <87woudknbm.fsf@morokweng.localdomain> (raw)
In-Reply-To: <1529979376-7292-4-git-send-email-linuxram@us.ibm.com>


Ram Pai <linuxram@us•ibm.com> writes:

> The test case assumes execute-permissions of unallocated keys are
> enabled by default.
>
> Signed-off-by: Ram Pai <linuxram@us•ibm.com>
> ---
>  .../testing/selftests/powerpc/ptrace/ptrace-pkey.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/tools/testing/selftests/powerpc/ptrace/ptrace-pkey.c b/tools/testing/selftests/powerpc/ptrace/ptrace-pkey.c
> index 5cf631f..559c6cb 100644
> --- a/tools/testing/selftests/powerpc/ptrace/ptrace-pkey.c
> +++ b/tools/testing/selftests/powerpc/ptrace/ptrace-pkey.c
> @@ -104,6 +104,11 @@ static int child(struct shared_info *info)
>
>  	if (disable_execute)
>  		info->expected_iamr |= 1ul << pkeyshift(pkey1);
> +	else
> +		info->expected_iamr &= ~(1ul << pkeyshift(pkey1));
> +	info->expected_iamr &= ~(1ul << pkeyshift(pkey2) | 1ul << pkeyshift(pkey3));
> +
> +
>
>  	info->expected_uamor |= 3ul << pkeyshift(pkey1) |
>  				3ul << pkeyshift(pkey2);

Reviewed-by: Thiago Jung Bauermann <bauerman@linux•ibm.com>

-- 
Thiago Jung Bauermann
IBM Linux Technology Center

  reply	other threads:[~2018-07-03  3:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-26  2:16 [PATCH 1/2] powerpc/pkeys: preallocate execute_only key only if the key is available Ram Pai
2018-06-26  2:16 ` [PATCH 2/2] powerpc/pkeys: key allocation/deallocation must not change pkey registers Ram Pai
2018-07-03  1:35   ` Thiago Jung Bauermann
2018-06-26  2:16 ` [PATCH 1/2] powerpc/core-pkeys: execute-permission on keys are disabled by default Ram Pai
2018-07-03  3:30   ` Thiago Jung Bauermann
2018-06-26  2:16 ` [PATCH 2/2] powerpc/ptrace-pkeys: " Ram Pai
2018-07-03  3:30   ` Thiago Jung Bauermann [this message]
2018-06-29  2:56 ` [PATCH 1/2] powerpc/pkeys: preallocate execute_only key only if the key is available Thiago Jung Bauermann
2018-06-29  6:07   ` Gabriel Paubert
2018-06-30  0:58     ` Thiago Jung Bauermann
2018-06-30  1:40       ` Ram Pai
2018-06-30 16:56       ` Gabriel Paubert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87woudknbm.fsf@morokweng.localdomain \
    --to=bauerman@linux$(echo .)ibm.com \
    --cc=Ulrich.Weigand@de$(echo .)ibm.com \
    --cc=bauerman@linux$(echo .)vnet.ibm.com \
    --cc=fweimer@redhat$(echo .)com \
    --cc=hbabu@us$(echo .)ibm.com \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    --cc=linuxram@us$(echo .)ibm.com \
    --cc=mhocko@kernel$(echo .)org \
    --cc=mpe@ellerman$(echo .)id.au \
    --cc=msuchanek@suse$(echo .)de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox