Subject: Re: [PATCH] [POWERPC] 83xx: Add support for the Thecus N1200 NAS device

From: Peter Korsgaard <[email-masked]>
Date: Fri, 05 Jun 2009 09:31:53 +0200

>>>>> "David" == David Gibson <[email-masked]> writes:

 David> On Thu, Jun 04, 2009 at 09:59:04PM +0100, Byron Bradley wrote:
 >> The Thecus N1200 is a NAS device with a single internal SATA disk and
 >> an eSATA port based on an MPC8347 SoC.

 David> Comments on a number of fairly minor device tree nits below:

 David> [snip]
 >> +	soc8349@e0000000 {
 >> +		#address-cells = <1>;
 >> +		#size-cells = <1>;
 >> +		device_type = "soc";
 >> +		compatible = "simple-bus";
 >> +		};
 >> +
 >> +		gpio1: gpio-controller@c00 {
 >> +			#gpio-cells = <2>;
 >> +			compatible = "fsl,mpc8347-gpio", "fsl,mpc8349-gpio";

 David> This actually is an 8349 board, yes?  Generally compatible should be
 David> listed from most specific to least specific, so the 8349 entry should
 David> go first.

No, it's an 8347, to the gpio compatible is fine, but the soc8349
should be changed to 8347 above.

-- 
Bye, Peter Korsgaard