From: Michael Ellerman <mpe@ellerman•id.au>
To: Ignat Korchagin <ignat@cloudflare•com>, eric.devolder@oracle•com
Cc: chenhuacai@kernel•org, linux-ia64@vger•kernel.org,
linux-sh@vger•kernel.org, Peter Zijlstra <peterz@infradead•org>,
catalin.marinas@arm•com, linus.walleij@linaro•org,
dave.hansen@linux•intel.com, linux-mips@vger•kernel.org,
James Bottomley <James.Bottomley@hansenpartnership•com>,
dalias@libc•org, hpa@zytor•com, linux-riscv@lists•infradead.org,
will@kernel•org, kernel@xen0n•name, tsi@tuyoix•net,
linux-s390@vger•kernel.org, agordeev@linux•ibm.com,
rmk+kernel@armlinux•org.uk, paulmck@kernel•org,
ysato@users•sourceforge.jp,
kernel-team <kernel-team@cloudflare•com>,
deller@gmx•de, x86@kernel•org, linux@armlinux•org.uk,
paul.walmsley@sifive•com, Ingo Molnar <mingo@redhat•com>,
geert@linux-m68k•org, hbathini@linux•ibm.com,
samitolvanen@google•com, ojeda@kernel•org,
juerg.haefliger@canonical•com, borntraeger@linux•ibm.com,
frederic@kernel•org, arnd@arndb•de, mhiramat@kernel•org,
Ard Biesheuvel <ardb@kernel•org>,
thunder.leizhen@huawei•com, aou@eecs•berkeley.edu,
keescook@chromium•org, go r@linux•ibm.com,
anshuman.khandual@arm•com, hca@linux•ibm.com, xin3.li@intel•com,
npiggin@gmail•com, konrad.wilk@oracle•com,
linux-m68k@lists•linux-m68k.org, Borislav Petkov <bp@alien8•de>,
loongarch@lists•linux.dev, glaubitz@physik•fu-berlin.de,
Thomas Gleixner <tglx@linutronix•de>,
ziy@nvidia•com, linux-arm-kernel@lists•infradead.org,
boris.ostrovsky@oracle•com, tsbogend@alpha•franken.de,
sebastian.reichel@collabora•com, bhe@redhat•com,
linux-parisc@vger•kernel.org,
Greg KH <gregkh@linuxfoundation•org>,
kirill.shutemov@linux•intel.com, ndesaulniers@google•com,
linux-kernel <linux-kernel@vger•kernel.org>,
sourabhjain@linux•ibm.com, palmer@dabbelt•com,
svens@linux•ibm.com, tj@kernel•org,
Andrew Morton <akpm@linux-foundation•org>,
linuxppc-dev@lists•ozlabs.org, masahiroy@kernel•org,
rppt@kernel•org
Subject: Re: Potential config regression after 89cde455 ("kexec: consolidate kexec and crash options into kernel/Kconfig.kexec")
Date: Tue, 21 Nov 2023 12:05:59 +1100 [thread overview]
Message-ID: <87y1er6hl4.fsf@mail.lhotse> (raw)
In-Reply-To: <CALrw=nHpRQQaQTP_jZfREgrQEMpS8jBF8JQCv4ygqXycE-StaA@mail.gmail.com>
Ignat Korchagin <ignat@cloudflare•com> writes:
> Good day!
>
> We have recently started to evaluate Linux 6.6 and noticed that we
> cannot disable CONFIG_KEXEC anymore, but keep CONFIG_CRASH_DUMP
> enabled. It seems to be related to commit 89cde455 ("kexec:
> consolidate kexec and crash options into kernel/Kconfig.kexec"), where
> a CONFIG_KEXEC dependency was added to CONFIG_CRASH_DUMP.
>
> In our current kernel (Linux 6.1) we only enable CONFIG_KEXEC_FILE
> with enforced signature check to support the kernel crash dumping
> functionality and would like to keep CONFIG_KEXEC disabled for
> security reasons [1].
>
> I was reading the long commit message, but the reason for adding
> CONFIG_KEXEC as a dependency for CONFIG_CRASH_DUMP evaded me. And I
> believe from the implementation perspective CONFIG_KEXEC_FILE should
> suffice here (as we successfully used it for crashdumps on Linux 6.1).
>
> Is there a reason for adding this dependency or is it just an
> oversight? Would some solution of requiring either CONFIG_KEXEC or
> CONFIG_KEXEC_FILE work here?
I don't actually see any reason for CRASH_DUMP to depend on KEXEC or
KEXEC_FILE.
None of the old CRASH_DUMP symbols depended on KEXEC AFAICS. Using
something like:
$ git diff 89cde455..95d1fef5 | grep -A 3 "^-.*config CRASH_DUMP"
It's reasonable to want to build a kernel that supports CRASH_DUMP (ie.
can be a dump kernel), but doesn't support kexec and requires a regular
reboot. Though I doubt anyone does that in practice?
cheers
next prev parent reply other threads:[~2023-11-21 2:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 22:52 Potential config regression after 89cde455 ("kexec: consolidate kexec and crash options into kernel/Kconfig.kexec") Ignat Korchagin
2023-11-21 1:05 ` Michael Ellerman [this message]
2023-11-21 1:50 ` Baoquan He
2023-11-21 7:53 ` Ignat Korchagin
2023-11-21 9:43 ` Ignat Korchagin
2023-11-22 9:34 ` Baoquan He
2023-11-22 9:47 ` Ignat Korchagin
2023-11-23 8:27 ` Baoquan He
2023-11-21 9:56 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1er6hl4.fsf@mail.lhotse \
--to=mpe@ellerman$(echo .)id.au \
--cc=James.Bottomley@hansenpartnership$(echo .)com \
--cc=agordeev@linux$(echo .)ibm.com \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=ardb@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=borntraeger@linux$(echo .)ibm.com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=chenhuacai@kernel$(echo .)org \
--cc=dalias@libc$(echo .)org \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=deller@gmx$(echo .)de \
--cc=eric.devolder@oracle$(echo .)com \
--cc=frederic@kernel$(echo .)org \
--cc=geert@linux-m68k$(echo .)org \
--cc=hbathini@linux$(echo .)ibm.com \
--cc=hpa@zytor$(echo .)com \
--cc=ignat@cloudflare$(echo .)com \
--cc=juerg.haefliger@canonical$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=kernel-team@cloudflare$(echo .)com \
--cc=kernel@xen0n$(echo .)name \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=mhiramat@kernel$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=ojeda@kernel$(echo .)org \
--cc=paul.walmsley@sifive$(echo .)com \
--cc=paulmck@kernel$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=rmk+kernel@armlinux$(echo .)org.uk \
--cc=samitolvanen@google$(echo .)com \
--cc=thunder.leizhen@huawei$(echo .)com \
--cc=tsi@tuyoix$(echo .)net \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=ysato@users$(echo .)sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox