From: Michael Ellerman <mpe@ellerman•id.au>
To: Tyrel Datwyler <tyreld@linux•ibm.com>, linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH 2/2] powerpc/prom_init: Pass linux_banner to firmware via option vector 7
Date: Wed, 23 Jun 2021 10:38:38 +1000 [thread overview]
Message-ID: <87y2b11kkx.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <bead9552-1e5c-2485-0463-4d161cce2a1f@linux.ibm.com>
Tyrel Datwyler <tyreld@linux•ibm.com> writes:
> On 6/20/21 11:49 PM, Michael Ellerman wrote:
>> Pass the value of linux_banner to firmware via option vector 7.
>>
>> Option vector 7 is described in "LoPAR" Linux on Power Architecture
>> Reference v2.9, in table B.7 on page 824:
>>
>> An ASCII character formatted null terminated string that describes
>> the client operating system. The string shall be human readable and
>> may be displayed on the console.
>>
>> The string can be up to 256 bytes total, including the nul terminator.
>>
>> linux_banner contains lots of information, and should make it possible
>> to identify the exact kernel version that is running:
>>
>> const char linux_banner[] =
>> "Linux version " UTS_RELEASE " (" LINUX_COMPILE_BY "@"
>> LINUX_COMPILE_HOST ") (" LINUX_COMPILER ") " UTS_VERSION "\n";
>>
>> For example:
>> Linux version 4.15.0-144-generic (buildd@bos02-ppc64el-018) (gcc
>> version 7.5.0 (Ubuntu 7.5.0-3ubuntu1~18.04)) #148-Ubuntu SMP Sat May 8
>> 02:32:13 UTC 2021 (Ubuntu 4.15.0-144.148-generic 4.15.18)
>>
>> It's also printed at boot to the console/dmesg, which should make it
>> possible to correlate what firmware receives with the console/dmesg on
>> the machine.
>>
>> Signed-off-by: Michael Ellerman <mpe@ellerman•id.au>
>> ---
>>
>> NB. linux_banner is already allowed by prom_init_check.sh
>>
>> LoPAR: https://openpowerfoundation.org/?resource_lib=linux-on-power-architecture-reference-a-papr-linux-subset-review-draft
>> ---
>> arch/powerpc/kernel/prom_init.c | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
>> index c18d55f8b951..7343076b261c 100644
>> --- a/arch/powerpc/kernel/prom_init.c
>> +++ b/arch/powerpc/kernel/prom_init.c
...
>> @@ -1340,6 +1351,10 @@ static void __init prom_check_platform_support(void)
>> memcpy(&ibm_architecture_vec, &ibm_architecture_vec_template,
>> sizeof(ibm_architecture_vec));
>>
>> + prom_strscpy_pad(ibm_architecture_vec.vec7.os_id, linux_banner, 256);
>> + // Ensure nul termination
>> + ibm_architecture_vec.vec7.os_id[255] = '\0';
>> +
>
> Doesn't the implementation of prom_strscpy_pad() in patch 1 ensure nul termination?
Yes! I was originally using strncpy(), but forgot to drop this when I
switched to strscpy_pad(). I dropped it when applying.
Thanks for reviewing.
cheers
next prev parent reply other threads:[~2021-06-23 0:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 6:49 [PATCH 1/2] powerpc/prom_init: Convert prom_strcpy() into prom_strscpy_pad() Michael Ellerman
2021-06-21 6:49 ` [PATCH 2/2] powerpc/prom_init: Pass linux_banner to firmware via option vector 7 Michael Ellerman
2021-06-22 18:11 ` Tyrel Datwyler
2021-06-23 0:38 ` Michael Ellerman [this message]
2021-06-21 12:57 ` [PATCH 1/2] powerpc/prom_init: Convert prom_strcpy() into prom_strscpy_pad() Daniel Axtens
2021-06-22 4:11 ` Michael Ellerman
2021-06-22 18:12 ` Tyrel Datwyler
2021-06-25 6:21 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2b11kkx.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=tyreld@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox