From: Michael Ellerman <mpe@ellerman•id.au>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Stephen Rothwell <sfr@canb•auug.org.au>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 2/3] powerpc/mm: Rename hpte_init_lpar() & put fallback in a header
Date: Wed, 27 Jul 2016 10:27:53 +1000 [thread overview]
Message-ID: <87y44nvsae.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <1469448688.5978.47.camel@kernel.crashing.org>
Benjamin Herrenschmidt <benh@kernel•crashing.org> writes:
> On Mon, 2016-07-25 at 20:36 +1000, Michael Ellerman wrote:
>> That would be nice, but these look fishy at least:
>>=20
>> arch/powerpc/platforms/cell/spu_manage.c:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 if (!firmware_has_feature(FW_FEATURE_LPAR))
>> arch/powerpc/platforms/cell/spu_manage.c:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 if (!firmware_has_feature(FW_FEATURE_LPAR)) {
>> > arch/powerpc/platforms/cell/spu_manage.c:=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0 if (!firmware_has_feature(FW_FEATURE_LPAR))
>
> Those can just be checks for LV1, I think ..=C2=A0
Yeah they can now.
Previously we had BEAT (the celleb HV), but now that's gone we can
switch those to LV1.
>> > arch/powerpc/platforms/pasemi/iommu.c:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 !=
firmware_has_feature(FW_FEATURE_LPAR)) {
>> drivers/net/ethernet/pasemi/pasemi_mac.c:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 return firmware_has_feature(FW_FEATURE_LPAR);
>
> And that was some experiemtal PAPR'ish thing wasn't it ?
Not sure, it was news to me that pasemi ever had any HV support.
cheers
next prev parent reply other threads:[~2016-07-27 0:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 2:57 [PATCH 1/3] powerpc/mm: Fix build break due when PPC_NATIVE=n Michael Ellerman
2016-07-25 2:57 ` [PATCH 2/3] powerpc/mm: Rename hpte_init_lpar() & put fallback in a header Michael Ellerman
2016-07-25 4:13 ` Stephen Rothwell
2016-07-25 4:42 ` Benjamin Herrenschmidt
2016-07-25 5:33 ` Michael Ellerman
2016-07-25 9:49 ` Benjamin Herrenschmidt
2016-07-25 10:36 ` Michael Ellerman
2016-07-25 12:11 ` Benjamin Herrenschmidt
2016-07-27 0:27 ` Michael Ellerman [this message]
2016-07-25 2:57 ` [PATCH 3/3] powerpc/mm: Drop unused externs for hpte_init_beat[_v3]() Michael Ellerman
2016-07-27 14:32 ` [3/3] " Michael Ellerman
2016-07-25 4:03 ` [PATCH 1/3] powerpc/mm: Fix build break due when PPC_NATIVE=n Stephen Rothwell
2016-07-25 6:17 ` Michael Ellerman
2016-07-25 10:39 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y44nvsae.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox