From: Stewart Smith <stewart@linux•vnet.ibm.com>
To: Vasant Hegde <hegdevasant@linux•vnet.ibm.com>,
benh@kernel•crashing.org, linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v3] powerpc/powernv Platform dump interface
Date: Wed, 05 Mar 2014 12:55:20 +1100 [thread overview]
Message-ID: <87y50pjto7.fsf@river.au.ibm.com> (raw)
In-Reply-To: <5315C592.4050605@linux.vnet.ibm.com>
Vasant Hegde <hegdevasant@linux•vnet.ibm.com> writes:
>> index 0000000..32fe7f5
>> --- /dev/null
>> +++ b/Documentation/ABI/stable/sysfs-firmware-opal-dump
>> @@ -0,0 +1,41 @@
>> +What: /sys/firmware/opal/dump
>> +Date: Feb 2014
>> +Contact: Stewart Smith <stewart@linux•vnet.ibm.com>
>> +Description:
>> + This directory exposes interfaces for interacting with
>> + the FSP and platform dumps through OPAL firmware interface.
>> +
>> + This is only for the powerpc/powernv platform.
>> +
>> + initiate_dump: When '1' is written to it,
>> + we will initiate a dump.
>
> initiate FSP dump
ack. I can send subsequent patch that fixes up these bits.
>> --- /dev/null
>> +++ b/arch/powerpc/platforms/powernv/opal-dump.c
>> @@ -0,0 +1,525 @@
>> +/*
>> + * PowerNV OPAL Dump Interface
>> + *
>> + * Copyright 2013,2014 IBM Corp.
>> + *
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License
>> + * as published by the Free Software Foundation; either version
>> + * 2 of the License, or (at your option) any later version.
>> + */
>> +
>> +#include <linux/kobject.h>
>> +#include <linux/mm.h>
>> +#include <linux/slab.h>
>> +#include <linux/vmalloc.h>
>> +#include <linux/pagemap.h>
>> +#include <linux/delay.h>
>> +
>> +#include <asm/opal.h>
>> +
>> +#define DUMP_TYPE_FSP 0x01
>
> Better define other dump type (sysdump etc) here and use it below ?
Likely yes, Is there a definitive list somewhere?
>> +static ssize_t init_dump_store(struct dump_obj *dump_obj,
>> + struct dump_attribute *attr,
>> + const char *buf,
>> + size_t count)
>> +{
>> + dump_fips_init(DUMP_TYPE_FSP);
>> + pr_info("%s: Initiated FSP dump\n", __func__);
>
> This might mislead if OPAL fails to initiate FSP dump.. Better move this to
> dump_fips_init () ?
good point. I don't think we actually process the response of FSP dump
init, which IIRC may actually be able to tell us if it failed to
initiate a dump.
next prev parent reply other threads:[~2014-03-05 1:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 1:58 [PATCH] powerpc/powernv Platform dump interface Stewart Smith
2014-02-26 5:42 ` [PATCH v2] " Stewart Smith
2014-03-02 23:25 ` [PATCH v3] " Stewart Smith
2014-03-04 12:22 ` Vasant Hegde
2014-03-05 1:51 ` Stewart Smith
2014-03-05 1:55 ` Stewart Smith [this message]
2014-03-05 3:25 ` Vasant Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y50pjto7.fsf@river.au.ibm.com \
--to=stewart@linux$(echo .)vnet.ibm.com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=hegdevasant@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox