From: Peter Korsgaard <jacmet@sunsite•dk>
To: John Linn <john.linn@xilinx•com>
Cc: linuxppc-dev@ozlabs•org, Sadanand <sadanan@xilinx•com>
Subject: Re: [PATCH] powerpc: Xilinx: PS2: Added new XPS PS2 driver
Date: Mon, 30 Jun 2008 16:45:04 +0200 [thread overview]
Message-ID: <87y74ndlsf.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20080630142451.516A41D1006C@mail57-sin.bigfish.com> (John Linn's message of "Mon\, 30 Jun 2008 07\:24\:48 -0700")
>>>>> "John" == John Linn <john.linn@xilinx•com> writes:
> Added a new driver for Xilinx XPS PS2 IP. This driver is
> a flat driver to better match the Linux driver pattern.
This should probably go to the linux-input@ list as well.
> Signed-off-by: Sadanand <sadanan@xilinx•com>
> Signed-off-by: John Linn <john.linn@xilinx•com>
> ---
> drivers/input/serio/Kconfig | 5 +
> drivers/input/serio/Makefile | 1 +
> drivers/input/serio/xilinx_ps2.c | 464 ++++++++++++++++++++++++++++++++++++++
> drivers/input/serio/xilinx_ps2.h | 97 ++++++++
> 4 files changed, 567 insertions(+), 0 deletions(-)
> create mode 100644 drivers/input/serio/xilinx_ps2.c
> create mode 100644 drivers/input/serio/xilinx_ps2.h
> diff --git a/drivers/input/serio/Kconfig b/drivers/input/serio/Kconfig
> index ec4b661..0e62b39 100644
> --- a/drivers/input/serio/Kconfig
> +++ b/drivers/input/serio/Kconfig
> @@ -190,4 +190,9 @@ config SERIO_RAW
> To compile this driver as a module, choose M here: the
> module will be called serio_raw.
> +config SERIO_XILINX_XPS_PS2
> + tristate "Xilinx XPS PS/2 Controller Support"
> + help
> + This driver supports XPS PS/2 IP from Xilinx EDK.
> +
> endif
> diff --git a/drivers/input/serio/Makefile b/drivers/input/serio/Makefile
> index 38b8868..9b6c813 100644
> --- a/drivers/input/serio/Makefile
> +++ b/drivers/input/serio/Makefile
> @@ -21,3 +21,4 @@ obj-$(CONFIG_SERIO_PCIPS2) += pcips2.o
> obj-$(CONFIG_SERIO_MACEPS2) += maceps2.o
> obj-$(CONFIG_SERIO_LIBPS2) += libps2.o
> obj-$(CONFIG_SERIO_RAW) += serio_raw.o
> +obj-$(CONFIG_SERIO_XILINX_XPS_PS2) += xilinx_ps2.o
> diff --git a/drivers/input/serio/xilinx_ps2.c b/drivers/input/serio/xilinx_ps2.c
> new file mode 100644
> index 0000000..670d47f
> --- /dev/null
> +++ b/drivers/input/serio/xilinx_ps2.c
> @@ -0,0 +1,464 @@
> +/*
> + * xilinx_ps2.c
> + *
> + * Xilinx PS/2 driver to interface PS/2 component to Linux
> + *
> + * Author: MontaVista Software, Inc.
> + * source@mvista•com
> + *
> + * (c) 2005 MontaVista Software, Inc.
> + * (c) 2008 Xilinx Inc.
> + *
Is the montavista stuff still valid?
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the
> + * Free Software Foundation; either version 2 of the License, or (at your
> + * option) any later version.
> + *
> + * You should have received a copy of the GNU General Public License along
> + * with this program; if not, write to the Free Software Foundation, Inc.,
> + * 675 Mass Ave, Cambridge, MA 02139, USA.
> + */
> +
> +
> +#include <linux/module.h>
> +#include <linux/serio.h>
> +#include <linux/interrupt.h>
> +#include <linux/errno.h>
> +#include <linux/init.h>
> +#include <linux/list.h>
> +#include <asm/io.h>
linux/io.h please.
> +
> +#ifdef CONFIG_OF /* For open firmware */
Why support !CONFIG_OF?
> + #include <linux/of_device.h>
> + #include <linux/of_platform.h>
> +#endif /* CONFIG_OF */
> +
> +#include "xilinx_ps2.h"
Why the seperate header? You're the only user of it, right?
> +
> +#define DRIVER_NAME "xilinx_ps2"
> +#define DRIVER_DESCRIPTION "Xilinx XPS PS/2 driver"
> +
> +#define XPS2_NAME_DESC "Xilinx XPS PS/2 Port #%d"
> +#define XPS2_PHYS_DESC "xilinxps2/serio%d"
Why have defines to stuff only used once?
...
> +
> +/******************************/
> +/* The platform device driver */
> +/******************************/
> +
> +static int xps2_probe(struct device *dev)
__devinit please.
> +{
> + struct platform_device *pdev = to_platform_device(dev);
> +
> + struct resource *irq_res = NULL; /* Interrupt resources */
> + struct resource *regs_res = NULL; /* IO mem resources */
> +
> + if (!dev) {
> + dev_err(dev, "Probe called with NULL param\n");
> + return -EINVAL;
> + }
> +
> + /* Find irq number, map the control registers in */
> + irq_res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> + regs_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + return xps2_setup(dev, pdev->id, regs_res, irq_res);
> +}
...
> +
> +/*
> + * xps2_remove() dissociates the driver with the Xilinx PS/2 device.
> + */
> +static int xps2_remove(struct device *dev)
__devexit please.
> +{
> + struct xps2data *drvdata;
> +
> + if (!dev)
> + return -EINVAL;
> +
> + drvdata = (struct xps2data *)dev_get_drvdata(dev);
> +
> + serio_unregister_port(&drvdata->serio);
> +
> + iounmap(drvdata->base_address);
> +
> + release_mem_region(drvdata->phys_addr, drvdata->remap_size);
> +
> + kfree(drvdata);
> + dev_set_drvdata(dev, NULL);
> +
> + return 0; /* success */
> +}
> +
> +static struct device_driver xps2_driver = {
Please use a real struct platform_driver instead.
> + .name = DRIVER_NAME,
> + .bus = &platform_bus_type,
> + .probe = xps2_probe,
> + .remove = xps2_remove
> +};
> +
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2008-06-30 14:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-30 14:24 [PATCH] powerpc: Xilinx: PS2: Added new XPS PS2 driver John Linn
2008-06-30 14:45 ` Peter Korsgaard [this message]
2008-06-30 14:46 ` John Linn
2008-06-30 19:41 ` John Linn
2008-06-30 17:16 ` Grant Likely
2008-06-30 18:10 ` Dmitry Torokhov
2008-06-30 18:53 ` Grant Likely
2008-06-30 20:00 ` John Linn
2008-06-30 22:45 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y74ndlsf.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite$(echo .)dk \
--cc=john.linn@xilinx$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=sadanan@xilinx$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox