Subject: Re: [PATCHv12 4/4] watchdog/softlockup: report the most frequent interrupts

From: Thomas Gleixner <[email-masked]>
Date: Sat, 23 Mar 2024 21:43:58 +0100

On Wed, Mar 06 2024 at 20:52, Bitao Hu wrote:
> +	if (__this_cpu_read(snapshot_taken)) {
> +		for_each_active_irq(i) {
> +			count = kstat_get_irq_since_snapshot(i);
> +			tabulate_irq_count(irq_counts_sorted, i, count, NUM_HARDIRQ_REPORT);
> +		}
> +
> +		/*
> +		 * We do not want the "watchdog: " prefix on every line,
> +		 * hence we use "printk" instead of "pr_crit".
> +		 */

You are not providing any justification why the prefix is not
wanted. Just saying 'We do not want' does not cut it and who is 'We'. I
certainly not.

I really disagree because the prefixes are very useful for searching log
files. So not having it makes it harder to filter out for no reason.

Thanks,

        tglx