From: Michael Ellerman <mpe@ellerman•id.au>
To: Nathan Chancellor <nathan@kernel•org>,
Nick Desaulniers <ndesaulniers@google•com>,
Andrew Morton <akpm@linux-foundation•org>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
linuxppc-dev@lists•ozlabs.org, Arnd Bergmann <arnd@kernel•org>,
Masahiro Yamada <masahiroy@kernel•org>,
llvm@lists•linux.dev, Rasmus Villemoes <linux@rasmusvillemoes•dk>,
linux-kernel@vger•kernel.org, Paul Mackerras <paulus@samba•org>,
Joe Perches <joe@perches•com>,
Linus Torvalds <torvalds@linux-foundation•org>
Subject: Re: [PATCH 06/10] powerpc: remove GCC version check for UPD_CONSTR
Date: Sat, 11 Sep 2021 20:43:57 +1000 [thread overview]
Message-ID: <87zgsjl7de.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <b940bd2c-21d2-dfe9-e171-e265085a2b11@kernel.org>
Nathan Chancellor <nathan@kernel•org> writes:
> On 9/10/2021 4:40 PM, Nick Desaulniers wrote:
>> Now that GCC 5.1 is the minimum supported version, we can drop this
>> workaround for older versions of GCC. This adversely affected clang,
>> too.
>>
>> Cc: Michael Ellerman <mpe@ellerman•id.au>
>> Cc: Benjamin Herrenschmidt <benh@kernel•crashing.org>
>> Cc: Paul Mackerras <paulus@samba•org>
>> Cc: Segher Boessenkool <segher@kernel•crashing.org>
>> Cc: Christophe Leroy <christophe.leroy@csgroup•eu>
>> Cc: linuxppc-dev@lists•ozlabs.org
>> Signed-off-by: Nick Desaulniers <ndesaulniers@google•com>
>> ---
>> arch/powerpc/include/asm/asm-const.h | 10 ----------
>> 1 file changed, 10 deletions(-)
>>
>> diff --git a/arch/powerpc/include/asm/asm-const.h b/arch/powerpc/include/asm/asm-const.h
>> index 0ce2368bd20f..dbfa5e1e3198 100644
>> --- a/arch/powerpc/include/asm/asm-const.h
>> +++ b/arch/powerpc/include/asm/asm-const.h
>> @@ -12,16 +12,6 @@
>> # define ASM_CONST(x) __ASM_CONST(x)
>> #endif
>>
>> -/*
>> - * Inline assembly memory constraint
>> - *
>> - * GCC 4.9 doesn't properly handle pre update memory constraint "m<>"
>> - *
>> - */
>> -#if defined(GCC_VERSION) && GCC_VERSION < 50000
>> -#define UPD_CONSTR ""
>> -#else
>> #define UPD_CONSTR "<>"
>> -#endif
>
> The only reason this exists is because of commit 592bbe9c505d
> ("powerpc/uaccess: Don't use "m<>" constraint with GCC 4.9"). It is
> probably just worth sinking "<>" into all of the callsites and removing
> UPD_CONSTR.
Yeah that would be great if you're doing a v2. Or we can do it as a
follow-up.
cheers
next prev parent reply other threads:[~2021-09-11 10:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210910234047.1019925-1-ndesaulniers@google.com>
2021-09-10 23:40 ` [PATCH 06/10] powerpc: remove GCC version check for UPD_CONSTR Nick Desaulniers
2021-09-10 23:48 ` Nathan Chancellor
2021-09-11 10:43 ` Michael Ellerman [this message]
2021-09-11 15:34 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgsjl7de.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=akpm@linux-foundation$(echo .)org \
--cc=arnd@kernel$(echo .)org \
--cc=joe@perches$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@rasmusvillemoes$(echo .)dk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=llvm@lists$(echo .)linux.dev \
--cc=masahiroy@kernel$(echo .)org \
--cc=nathan@kernel$(echo .)org \
--cc=ndesaulniers@google$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox