From: Michael Ellerman <mpe@ellerman•id.au>
To: kernel test robot <lkp@intel•com>,
Nicholas Piggin <npiggin@gmail•com>,
linuxppc-dev@lists•ozlabs.org
Cc: kbuild-all@lists•01.org, "Nicholas Piggin" <npiggin@gmail•com>,
kvm-ppc@vger•kernel.org, "Anton Blanchard" <anton@linux•ibm.com>,
"Cédric Le Goater" <clg@kaod•org>,
"David Gibson" <david@gibson•dropbear.id.au>
Subject: Re: [PATCH 1/3] powerpc: inline doorbell sending functions
Date: Tue, 30 Jun 2020 11:31:15 +1000 [thread overview]
Message-ID: <87zh8l7318.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <202006280326.fcRFUNzs%lkp@intel.com>
kernel test robot <lkp@intel•com> writes:
> Hi Nicholas,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on powerpc/next]
> [also build test ERROR on scottwood/next v5.8-rc2 next-20200626]
> [cannot apply to kvm-ppc/kvm-ppc-next]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Nicholas-Piggin/powerpc-pseries-IPI-doorbell-improvements/20200627-230544
> base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
> config: powerpc-randconfig-c003-20200628 (attached as .config)
> compiler: powerpc64-linux-gcc (GCC) 9.3.0
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel•com>
>
> All error/warnings (new ones prefixed by >>):
>
> In file included from arch/powerpc/kernel/asm-offsets.c:38:
> arch/powerpc/include/asm/dbell.h: In function 'doorbell_global_ipi':
>>> arch/powerpc/include/asm/dbell.h:114:12: error: implicit declaration of function 'get_hard_smp_processor_id'; did you mean 'raw_smp_processor_id'? [-Werror=implicit-function-declaration]
> 114 | u32 tag = get_hard_smp_processor_id(cpu);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> | raw_smp_processor_id
> arch/powerpc/include/asm/dbell.h: In function 'doorbell_try_core_ipi':
>>> arch/powerpc/include/asm/dbell.h:146:28: error: implicit declaration of function 'cpu_sibling_mask'; did you mean 'cpu_online_mask'? [-Werror=implicit-function-declaration]
> 146 | if (cpumask_test_cpu(cpu, cpu_sibling_mask(this_cpu))) {
> | ^~~~~~~~~~~~~~~~
> | cpu_online_mask
>>> arch/powerpc/include/asm/dbell.h:146:28: warning: passing argument 2 of 'cpumask_test_cpu' makes pointer from integer without a cast [-Wint-conversion]
> 146 | if (cpumask_test_cpu(cpu, cpu_sibling_mask(this_cpu))) {
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
Seems like CONFIG_SMP=n is probably the root cause.
You could try including asm/smp.h, but good chance that will lead to
header soup.
Other option would be to wrap the whole lot in #ifdef CONFIG_SMP?
cheers
next prev parent reply other threads:[~2020-06-30 1:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-27 15:04 [PATCH 0/3] powerpc/pseries: IPI doorbell improvements Nicholas Piggin
2020-06-27 15:04 ` [PATCH 1/3] powerpc: inline doorbell sending functions Nicholas Piggin
2020-06-27 19:46 ` kernel test robot
2020-06-30 1:31 ` Michael Ellerman [this message]
2020-06-30 1:58 ` Nicholas Piggin
2020-06-27 15:04 ` [PATCH 2/3] powerpc/pseries: Use doorbells even if XIVE is available Nicholas Piggin
2020-06-27 15:04 ` [PATCH 3/3] powerpc/pseries: Add KVM guest doorbell restrictions Nicholas Piggin
2020-06-30 2:27 ` Paul Mackerras
2020-06-30 5:35 ` Nicholas Piggin
2020-06-30 8:26 ` Paul Mackerras
2020-06-30 11:57 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh8l7318.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=anton@linux$(echo .)ibm.com \
--cc=clg@kaod$(echo .)org \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=kbuild-all@lists$(echo .)01.org \
--cc=kvm-ppc@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lkp@intel$(echo .)com \
--cc=npiggin@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox